linux-kernel - Re: [PATCH] rust: page: Simplify overflow check using checked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC=eVgSkqruKPn=-5RJW-1SR5TmPRj5BtbPH0Nu3_kuUqk53Eg@mail.gmail.com>
Date: Sat, 20 Dec 2025 14:53:43 +0200
From: Kari Argillander <kari.argillander@...il.com>
To: Dirk Behme <dirk.behme@...il.com>
Cc: Alice Ryhl <aliceryhl@...gle.com>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, 
	"Liam R. Howlett" <Liam.Howlett@...cle.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, linux-mm@...ck.org, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: page: Simplify overflow check using checked_add()

On 20.12.2025 10.41 Dirk Behme (dirk.behme@...il.com) wrote:
>
> On 19.12.25 22:29, Kari Argillander wrote:
> > Option::is_none_or() would be nicer, but it requires Rust 1.82; the
> > kernel currently targets 1.78.
> >
>
> I just wonder if we would like to add a comment like
>
> // TODO: replace `map_or` with `is_none_or` once the MSRV is >= 1.82.
>
> like we do in e.g. transmute.rs [2]?

Sure, I can do that. I’ll send a respin maybe next Tuesday.

> [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/kernel/transmute.rs#n75