linux-kernel - Re: [PATCH v3 3/3] overflow: Remove is_non_negative() and is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUacIe84RuAxGV6W@levanger>
Date: Sat, 20 Dec 2025 13:52:49 +0100
From: Nicolas Schier <nsc@...nel.org>
To: Vincent Mailhol <mailhol@...nel.org>
Cc: Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
	Kees Cook <kees@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kbuild@...r.kernel.org, linux-sparse@...r.kernel.org,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	dri-devel@...ts.freedesktop.org, linux-btrfs@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v3 3/3] overflow: Remove is_non_negative() and
 is_negative()

On Sat, Dec 20, 2025 at 12:02:21PM +0100, Vincent Mailhol wrote:
> The is_non_negative() and is_negative() function-like macros just
> exist as a workaround to silence the -Wtype-limits warning. Now that
> this warning is disabled, those two macros have lost their raison
> d'être. Remove them.
> 
> This reverts commit dc7fe518b049 ("overflow: Fix -Wtype-limits
> compilation warnings").
> 
> Suggested-by: Nicolas Schier <nsc@...nel.org>
> Link: https://lore.kernel.org/all/aUT_yWin_xslnOFh@derry.ads.avm.de
> Signed-off-by: Vincent Mailhol <mailhol@...nel.org>
> ---
> Changelog:
> 
>   v1 -> v2: new patch
> ---
>  include/linux/overflow.h | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 

Thanks!

Reviewed-by: Nicolas Schier <nsc@...nel.org>