linux-kernel - Re: [PATCH] sh: dma-sysfs: add missing put_device() in dma_create_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e412a9834ced553c4eb757362a122d26f16213f.camel@physik.fu-berlin.de>
Date: Sat, 20 Dec 2025 15:11:06 +0100
From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To: Markus Elfring <Markus.Elfring@....de>, Haoxiang Li	
 <lihaoxiang@...c.iscas.ac.cn>, linux-sh@...r.kernel.org, Greg Kroah-Hartman
	 <gregkh@...uxfoundation.org>, Kay Sievers <kay.sievers@...y.org>, Rich
 Felker	 <dalias@...c.org>, Yoshinori Sato <ysato@...rs.sourceforge.jp>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sh: dma-sysfs: add missing put_device() in
 dma_create_sysfs_files()

Hi Markus,

On Sat, 2025-12-20 at 14:56 +0100, Markus Elfring wrote:
> > If device_register() fails, call put_device() to drop the device
> > reference. Also, call device_unregister() if device_create_file()
> > fails.
> 
> See also once more:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc1#n659
> 
> 
> You propose to complete the exception handling for two cases.
> Is there a need to indicate such a detail in the summary phrase accordingly?

Maybe I'm completely missing something here, but I find the description short
and reasonable. As the SH maintainer, I haven't started reviewing these patches
themselves yet, I definitely interested to understand what the problem is.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913