linux-kernel - Re: [PATCH] PNP: add put_device() in pnpbios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202512210013.9DqxXceY-lkp@intel.com>
Date: Sun, 21 Dec 2025 00:41:47 +0800
From: kernel test robot <lkp@...el.com>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>, rafael@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] PNP: add put_device() in pnpbios_init()

Hi Haoxiang,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.19-rc1 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Haoxiang-Li/PNP-add-put_device-in-pnpbios_init/20251218-162345
base:   linus/master
patch link:    https://lore.kernel.org/r/20251218081955.548521-1-lihaoxiang%40isrc.iscas.ac.cn
patch subject: [PATCH] PNP: add put_device() in pnpbios_init()
config: i386-randconfig-004-20251219 (https://download.01.org/0day-ci/archive/20251221/202512210013.9DqxXceY-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251221/202512210013.9DqxXceY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512210013.9DqxXceY-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/pnp/pnpbios/core.c:90:13: warning: variable 'value' set but not used [-Wunused-but-set-variable]
      90 |         int i = 0, value;
         |                    ^
>> drivers/pnp/pnpbios/core.c:542:3: error: expected expression
     542 |                 printk(KERN_ERR
         |                 ^
   include/linux/printk.h:512:26: note: expanded from macro 'printk'
     512 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                          ^
   include/linux/printk.h:482:3: note: expanded from macro 'printk_index_wrap'
     482 |         ({                                                              \
         |          ^
   1 warning and 1 error generated.


vim +542 drivers/pnp/pnpbios/core.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  522  
^1da177e4c3f41 Linus Torvalds 2005-04-16  523  	/* scan the system for pnpbios support */
^1da177e4c3f41 Linus Torvalds 2005-04-16  524  	if (!pnpbios_probe_system())
^1da177e4c3f41 Linus Torvalds 2005-04-16  525  		return -ENODEV;
^1da177e4c3f41 Linus Torvalds 2005-04-16  526  
^1da177e4c3f41 Linus Torvalds 2005-04-16  527  	/* make preparations for bios calls */
^1da177e4c3f41 Linus Torvalds 2005-04-16  528  	pnpbios_calls_init(pnp_bios_install);
^1da177e4c3f41 Linus Torvalds 2005-04-16  529  
^1da177e4c3f41 Linus Torvalds 2005-04-16  530  	/* read the node info */
^1da177e4c3f41 Linus Torvalds 2005-04-16  531  	ret = pnp_bios_dev_node_info(&node_info);
^1da177e4c3f41 Linus Torvalds 2005-04-16  532  	if (ret) {
9dd78466c956ac Bjorn Helgaas  2007-07-26  533  		printk(KERN_ERR
9dd78466c956ac Bjorn Helgaas  2007-07-26  534  		       "PnPBIOS: Unable to get node info.  Aborting.\n");
^1da177e4c3f41 Linus Torvalds 2005-04-16  535  		return ret;
^1da177e4c3f41 Linus Torvalds 2005-04-16  536  	}
^1da177e4c3f41 Linus Torvalds 2005-04-16  537  
^1da177e4c3f41 Linus Torvalds 2005-04-16  538  	/* register with the pnp layer */
^1da177e4c3f41 Linus Torvalds 2005-04-16  539  	ret = pnp_register_protocol(&pnpbios_protocol);
^1da177e4c3f41 Linus Torvalds 2005-04-16  540  	if (ret) {
72a4fc1c3483e8 Haoxiang Li    2025-12-18  541  		put_device(&pnpbios_protocol.dev)
9dd78466c956ac Bjorn Helgaas  2007-07-26 @542  		printk(KERN_ERR
9dd78466c956ac Bjorn Helgaas  2007-07-26  543  		       "PnPBIOS: Unable to register driver.  Aborting.\n");
^1da177e4c3f41 Linus Torvalds 2005-04-16  544  		return ret;
^1da177e4c3f41 Linus Torvalds 2005-04-16  545  	}
^1da177e4c3f41 Linus Torvalds 2005-04-16  546  
^1da177e4c3f41 Linus Torvalds 2005-04-16  547  	/* start the proc interface */
^1da177e4c3f41 Linus Torvalds 2005-04-16  548  	ret = pnpbios_proc_init();
^1da177e4c3f41 Linus Torvalds 2005-04-16  549  	if (ret)
^1da177e4c3f41 Linus Torvalds 2005-04-16  550  		printk(KERN_ERR "PnPBIOS: Failed to create proc interface.\n");
^1da177e4c3f41 Linus Torvalds 2005-04-16  551  
^1da177e4c3f41 Linus Torvalds 2005-04-16  552  	/* scan for pnpbios devices */
^1da177e4c3f41 Linus Torvalds 2005-04-16  553  	build_devlist();
^1da177e4c3f41 Linus Torvalds 2005-04-16  554  
8f81dd149806bc Bjorn Helgaas  2007-05-08  555  	pnp_platform_devices = 1;
^1da177e4c3f41 Linus Torvalds 2005-04-16  556  	return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  557  }
^1da177e4c3f41 Linus Torvalds 2005-04-16  558  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki