linux-kernel - [PATCH 2/2] scsi: fcoe: replace -EEXIST with -EBUSY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251220-dev-module-init-eexists-linux-scsi-v1-2-5379db749d54@samsung.com>
Date: Sat, 20 Dec 2025 04:37:33 +0100
From: Daniel Gomez <da.gomez@...nel.org>
To: "Martin K. Petersen" <martin.petersen@...cle.com>, 
 Hannes Reinecke <hare@...e.de>, 
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>
Cc: Luis Chamberlain <mcgrof@...nel.org>, Petr Pavlu <petr.pavlu@...e.com>, 
 Daniel Gomez <da.gomez@...nel.org>, Sami Tolvanen <samitolvanen@...gle.com>, 
 Aaron Tomlin <atomlin@...mlin.com>, Lucas De Marchi <demarchi@...nel.org>, 
 linux-scsi@...r.kernel.org, target-devel@...r.kernel.org, 
 linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Daniel Gomez <da.gomez@...sung.com>
Subject: [PATCH 2/2] scsi: fcoe: replace -EEXIST with -EBUSY

From: Daniel Gomez <da.gomez@...sung.com>

The -EEXIST error code is reserved by the module loading infrastructure
to indicate that a module is already loaded. When a module's init
function returns -EEXIST, userspace tools like kmod interpret this as
"module already loaded" and treat the operation as successful, returning
0 to the user even though the module initialization actually failed.

This follows the precedent set by commit 54416fd76770 ("netfilter:
conntrack: helper: Replace -EEXIST by -EBUSY") which fixed the same
issue in nf_conntrack_helper_register().

Affected modules:
  * bnx2fc fcoe

Signed-off-by: Daniel Gomez <da.gomez@...sung.com>
---
 drivers/scsi/fcoe/fcoe_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c
index 2f478426f16e..d0f9ff4893e3 100644
--- a/drivers/scsi/fcoe/fcoe_transport.c
+++ b/drivers/scsi/fcoe/fcoe_transport.c
@@ -533,7 +533,7 @@ int fcoe_transport_attach(struct fcoe_transport *ft)
 	if (ft->attached) {
 		LIBFCOE_TRANSPORT_DBG("transport %s already attached\n",
 				       ft->name);
-		rc = -EEXIST;
+		rc = -EBUSY;
 		goto out_attach;
 	}

-- 
2.52.0