linux-kernel - Re: [PATCH v4 0/2] kallsyms: Always initialize modbuildid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9ab026c91a2e7da84702d9fd2455ae64f25b32a.camel@mailbox.org>
Date: Sun, 21 Dec 2025 19:44:55 +0100
From: Maurice Hieronymus <mhi@...lbox.org>
To: ast@...nel.org, daniel@...earbox.net, john.fastabend@...il.com, 
 andrii@...nel.org, martin.lau@...ux.dev, eddyz87@...il.com,
 song@...nel.org,  yonghong.song@...ux.dev, kpsingh@...nel.org,
 sdf@...ichev.me, haoluo@...gle.com,  jolsa@...nel.org, rostedt@...dmis.org,
 mhiramat@...nel.org, mark.rutland@....com,  mathieu.desnoyers@...icios.com
Cc: georges.aureau@....com, bpf@...r.kernel.org,
 linux-kernel@...r.kernel.org,  linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/2] kallsyms: Always initialize modbuildid

On Sat, 2025-12-20 at 19:18 +0100, Maurice Hieronymus wrote:
> modbuildid is never set when kallsyms_lookup_buildid is returning via
> successful bpf_address_lookup or ftrace_mod_address_lookup.
> 
> This leads to an uninitialized pointer dereference on x86 when
> CONFIG_STACKTRACE_BUILD_ID=y inside __sprint_symbol.
> 
> Prevent this by always initializing modbuildid.
> 
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220717
> 
> Changes to v3:
> - Split the changes into separate ftrace and bpf patches
> - Replace IS_ENABLED() with plain #ifdef
> 
> Maurice Hieronymus (2):
>   kallsyms: Always initialize modbuildid on ftrace address
>   kallsyms: Always initialize modbuildid on bpf address
> 
>  include/linux/filter.h | 6 ++++--
>  include/linux/ftrace.h | 4 ++--
>  kernel/kallsyms.c      | 4 ++--
>  kernel/trace/ftrace.c  | 8 +++++++-
>  4 files changed, 15 insertions(+), 7 deletions(-)
> 
> 
> base-commit: dd9b004b7ff3289fb7bae35130c0a5c0537266af

This patch is obsolete and already fixed by [1]

[1]
https://lore.kernel.org/bpf/20251128135920.217303-1-pmladek@suse.com/#t