linux-kernel - Re: [PATCH 1/5] staging: iio: ad9832: clean up whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251221191730.607eaf34@jic23-huawei>
Date: Sun, 21 Dec 2025 19:17:30 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: Tomas Borquez <tomasborquez13@...il.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH 1/5] staging: iio: ad9832: clean up whitespace

On Thu, 18 Dec 2025 11:27:18 -0300
Marcelo Schmitt <marcelo.schmitt1@...il.com> wrote:

> Hi Tomas,
> 
> LGTM.
> One minor suggestion.
> 
> On 12/15, Tomas Borquez wrote:
> > Remove unnecessary blank lines between comment sections to improve
> > readability.
> > 
> > Signed-off-by: Tomas Borquez <tomasborquez13@...il.com>
> > ---
> >  drivers/staging/iio/frequency/ad9832.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> > index e2ad3e5a7a..00813dab7c 100644
> > --- a/drivers/staging/iio/frequency/ad9832.c
> > +++ b/drivers/staging/iio/frequency/ad9832.c
> > @@ -26,7 +26,6 @@
> >  #include "dds.h"
> >  
> >  /* Registers */
> > -
> >  #define AD9832_FREQ0LL		0x0
> >  #define AD9832_FREQ0HL		0x1
> >  #define AD9832_FREQ0LM		0x2
> > @@ -50,7 +49,6 @@
> >  #define AD9832_OUTPUT_EN	0x13  
> 
> There is a blank line between AD9832_PHASE3H and AD9832_PHASE_SYM that could
> also be removed, IMO.
>  #define AD9832_PHASE3L		0xE
>  #define AD9832_PHASE3H		0xF
> -
>  #define AD9832_PHASE_SYM	0x10
>  #define AD9832_FREQ_SYM		0x11
> 
Agreed. In the interests of efficiency all round I applied this
tweak whilst picking up the patch.

For this sort of cleanup series I often to it piecemeal. So I've
applied this one (no idea if I'll apply the later ones yet!)

Jonathan

> >  
> >  /* Command Control Bits */
> > -
> >  #define AD9832_CMD_PHA8BITSW	0x1