linux-kernel - Re: [PATCH] platform/x86: asus-nb-wmi: Add keymap for display toggle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c2e0f32-8110-4bf1-9c5a-e4d6dbfecc7e@gmail.com>
Date: Sun, 21 Dec 2025 20:30:52 +0100
From: Denis Benato <benato.denis96@...il.com>
To: Tim Wassink <timwassink.dev@...il.com>,
 platform-driver-x86@...r.kernel.org
Cc: Corentin Chary <corentin.chary@...il.com>, "Luke D. Jones"
 <luke@...nes.dev>, Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-nb-wmi: Add keymap for display toggle


On 12/21/25 19:17, Tim Wassink wrote:
> On the Asus Zenbook 14 (UX3405MA), the Fn+F7 key combination emits
> WMI code 0x2d, which was previously unmapped.
As in "unapped scancode: 0x2d" in dmesg?
> Map this code to KEY_DISPLAYTOGGLE. This matches the behavior of the
> display toggle/projector mode key found on other Asus laptops, allowing
> userspace to handle multi-monitor switching or screen toggling.
>
> Tested on ASUS Zenbook 14 UX3405MA.
>
> Signed-off-by: Tim Wassink <timwassink.dev@...il.com>
Thank you for this!

Reviewed-by: Denis Benato <benato.denis96@...il.com>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 6a62bc5b02fd..a38a65f5c550 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -580,6 +580,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>  	{ KE_KEY, 0x2a, { KEY_SELECTIVE_SCREENSHOT } },
>  	{ KE_IGNORE, 0x2b, }, /* PrintScreen (also send via PS/2) on newer models */
>  	{ KE_IGNORE, 0x2c, }, /* CapsLock (also send via PS/2) on newer models */
> +	{ KE_KEY, 0x2d, { KEY_DISPLAYTOGGLE } },
>  	{ KE_KEY, 0x30, { KEY_VOLUMEUP } },
>  	{ KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
>  	{ KE_KEY, 0x32, { KEY_MUTE } },