linux-kernel - Re: [PATCH] drm/xe: Don't use absolute path in generated header comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUhQHcgL4U-HgSv6@mozart.vkv.me>
Date: Sun, 21 Dec 2025 11:53:01 -0800
From: Calvin Owens <calvin@...nvd.org>
To: linux-kernel@...r.kernel.org
Cc: Lucas De Marchi <lucas.demarchi@...el.com>,
	thomas.hellstrom@...ux.intel.com,
	Rodrigo Vivi <rodrigo.vivi@...el.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	intel-xe@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/xe: Don't use absolute path in generated header
 comment

On Friday 10/31 at 07:48 -0700, Calvin Owens wrote:
> Building the XE driver through Yocto throws this QA warning:
> 
>     WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue: File /usr/src/debug/linux-stable/6.17/drivers/gpu/drm/xe/generated/xe_device_wa_oob.h in package linux-stable-src contains reference to TMPDIR [buildpaths]
>     WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue: File /usr/src/debug/linux-stable/6.17/drivers/gpu/drm/xe/generated/xe_wa_oob.h in package linux-stable-src contains reference to TMPDIR [buildpaths]
> 
> ...because the comment at the top of the generated header contains the
> absolute path to the rules file at build time:
> 
>     * This file was generated from rules: /home/calvinow/git/meta-house/build/tmp-house/work-shared/nuc14rvhu7/kernel-source/drivers/gpu/drm/xe/xe_device_wa_oob.rules
> 
> Fix this minor annoyance by putting the basename of the rules file in
> the generated comment instead of the absolute path, so the generated
> header contents no longer depend on the location of the kernel source.

Hi all,

This is about as trivial as it gets: it's been a couple months, can I
get some eyes on this please?

This is the only place in the entire kernel source where the content of
a generated header depends on the absolute path to the kernel tree. It
makes kernel source packages non-reproducible.

Thanks
Calvin

> Signed-off-by: Calvin Owens <calvin@...nvd.org>
> ---
>  drivers/gpu/drm/xe/xe_gen_wa_oob.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gen_wa_oob.c b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> index 247e41c1c48d..e7a50b1348b7 100644
> --- a/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> +++ b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> @@ -195,7 +195,8 @@ int main(int argc, const char *argv[])
>  		}
>  	}
>  
> -	fprintf(args[ARGS_CHEADER].f, HEADER, args[ARGS_INPUT].fn, prefix, prefix);
> +	fprintf(args[ARGS_CHEADER].f, HEADER, xbasename(args[ARGS_INPUT].fn),
> +		prefix, prefix);
>  
>  	ret = parse(args[ARGS_INPUT].f, args[ARGS_CSOURCE].f,
>  		    args[ARGS_CHEADER].f, prefix);
> -- 
> 2.47.3
>