[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4a0f381d-94e8-4e05-838a-5e90c6627fbc@gtucker.io>
Date: Sun, 21 Dec 2025 21:04:09 +0100
From: Guillaume Tucker <gtucker@...cker.io>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, linux-kernel@...r.kernel.org,
rust-for-linux@...r.kernel.org, linux-kbuild@...r.kernel.org,
automated-testing@...ts.yoctoproject.org, workflows@...r.kernel.org,
llvm@...ts.linux.dev, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v1 1/2] scripts: add tool to run containerized builds
Hi Nathan,
On 19/12/2025 10:15 pm, Nathan Chancellor wrote:
> On Fri, Dec 19, 2025 at 12:47:48PM -0700, Nathan Chancellor wrote:
>> Most of these two functions are the same. Maybe they could be abstracted
>> into a simple class so that most of the logic could be shared between
>> the two implementations? That also might simplify main() a bit and make
>> fulfilling David's request a little simpler as well.
>
> Sigh, this is what I get for working through my inbox bottom up since I
> see that you did this in v2 :) looks good, I will give a couple more
> comments there.
Thank you twice for the reviews then :) Yes I'm glad the v2
pre-addressed some of the things you mentioned. I'll reply there too
regarding user id management etc.
In the meantime I also started this thread about container images:
https://lore.kernel.org/all/cc737636-2a43-4a97-975e-4725733f7ee4@gtucker.io/
I believe this will go hand-in-hand with the scripts/container tool,
not with hard dependencies but they will enhance each other.
Cheers,
Guillaume
Powered by blists - more mailing lists