linux-kernel - [PATCH v2 1/5] selftests/mm: fix va_high_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251221040025.3159990-1-chuhu@redhat.com>
Date: Sun, 21 Dec 2025 12:00:21 +0800
From: Chunyu Hu <chuhu@...hat.com>
To: akpm@...ux-foundation.org,
	david@...nel.org,
	shuah@...nel.org,
	linux-mm@...ck.org
Cc: linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	lorenzo.stoakes@...cle.com,
	Liam.Howlett@...cle.com,
	vbabka@...e.cz,
	rppt@...nel.org,
	surenb@...gle.com,
	mhocko@...e.com,
	chuhu@...hat.com,
	Luiz Capitulino <luizcap@...hat.com>
Subject: [PATCH v2 1/5] selftests/mm: fix va_high_addr_switch.sh return value

Patch series "Fix va_high_addr_switch.sh test failure - again", v2.

The series address several issues exist for the va_high_addr_switch test:
1) the test return value is ignored in va_high_addr_switch.sh.
2) the va_high_addr_switch test requires 6 hugepages not 5.
3) the reurn value of the first test in va_high_addr_switch.c can be
   overridden by the second test.
4) the nr_hugepages setup in run_vmtests.sh for arm64 can be done in
   va_high_addr_switch.sh too.
5) update a comment for check_test_requirements.

Changes in v2:
 - shorten the comment in for hugepages setup in v1
 - add a new patch to fix the return value overridden issue in
   va_high_addr_switch.c
 - fix a code comment for check_test_requirements.
 - update the series summary in patch 1
 - add reviewed-by from Luiz Capitulino on patch 1 and patch 3

This patch: (of 5)

The return value should be return value of va_high_addr_switch, otherwise
a test failure would be silently ignored.

Reviewed-by: Luiz Capitulino <luizcap@...hat.com>
Fixes: d9d957bd7b61 ("selftests/mm: alloc hugepages in va_high_addr_switch test")
CC: Luiz Capitulino <luizcap@...hat.com>
Signed-off-by: Chunyu Hu <chuhu@...hat.com>
---
Chunyu Hu (5):
  selftests/mm: fix va_high_addr_switch.sh return value
  selftests/mm: allocate 6 hugepages in va_high_addr_switch.sh
  selftests/mm: remove arm64 nr_hugepages setup for va_high_addr_switch
    test
  selftests/mm: va_high_addr_switch return fail when either test failed
  selftests/mm: fix comment for check_test_requirements

 tools/testing/selftests/mm/run_vmtests.sh         |  8 --------
 tools/testing/selftests/mm/va_high_addr_switch.c  | 10 +++++++---
 tools/testing/selftests/mm/va_high_addr_switch.sh | 12 +++++++-----
 3 files changed, 14 insertions(+), 16 deletions(-)

According to the doc below, I don't add the cover letter, not sure if cover
letter is preferred, and if that's the case, the doc need an update.
https://www.ozlabs.org/~akpm/stuff/tpp.txt
---
 tools/testing/selftests/mm/va_high_addr_switch.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh
index a7d4b02b21dd..f89fe078a8e6 100755
--- a/tools/testing/selftests/mm/va_high_addr_switch.sh
+++ b/tools/testing/selftests/mm/va_high_addr_switch.sh
@@ -114,4 +114,6 @@ save_nr_hugepages
 # 4 keep_mapped pages, and one for tmp usage
 setup_nr_hugepages 5
 ./va_high_addr_switch --run-hugetlb
+retcode=$?
 restore_nr_hugepages
+exit $retcode
-- 
2.49.0