[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20251221064754.1783369-1-wens@kernel.org>
Date: Sun, 21 Dec 2025 14:47:52 +0800
From: Chen-Yu Tsai <wens@...nel.org>
To: Vinod Koul <vkoul@...nel.org>
Cc: Chen-Yu Tsai <wens@...nel.org>,
dmaengine@...r.kernel.org,
linux-sunxi@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org,
Jernej Skrabec <jernej.skrabec@...il.com>
Subject: [PATCH RESEND] dmaengine: sun6i: Add debug messages for cyclic DMA prepare
The driver already has debug messages for memcpy and linear transfers,
but is missing them for cyclic transfers.
Cyclic transfers are one of the main uses of the DMA controller, used
for audio data transfers. And since these are likely the first DMA
peripherals to be enabled, it helps to have these debug messages.
Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>
Signed-off-by: Chen-Yu Tsai <wens@...nel.org>
---
Hi Vinod,
This patch seems to have fallen through the cracks.
drivers/dma/sun6i-dma.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
index 2215ff877bf7..2e03c587bd2e 100644
--- a/drivers/dma/sun6i-dma.c
+++ b/drivers/dma/sun6i-dma.c
@@ -826,6 +826,11 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_dma_cyclic(
v_lli->cfg = lli_cfg;
sdev->cfg->set_drq(&v_lli->cfg, DRQ_SDRAM, vchan->port);
sdev->cfg->set_mode(&v_lli->cfg, LINEAR_MODE, IO_MODE);
+ dev_dbg(chan2dev(chan),
+ "%s; chan: %d, dest: %pad, src: %pad, len: %zu. flags: 0x%08lx\n",
+ __func__, vchan->vc.chan.chan_id,
+ &sconfig->dst_addr, &buf_addr,
+ buf_len, flags);
} else {
sun6i_dma_set_addr(sdev, v_lli,
sconfig->src_addr,
@@ -833,6 +838,11 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_dma_cyclic(
v_lli->cfg = lli_cfg;
sdev->cfg->set_drq(&v_lli->cfg, vchan->port, DRQ_SDRAM);
sdev->cfg->set_mode(&v_lli->cfg, IO_MODE, LINEAR_MODE);
+ dev_dbg(chan2dev(chan),
+ "%s; chan: %d, dest: %pad, src: %pad, len: %zu. flags: 0x%08lx\n",
+ __func__, vchan->vc.chan.chan_id,
+ &buf_addr, &sconfig->src_addr,
+ buf_len, flags);
}
prev = sun6i_dma_lli_add(prev, v_lli, p_lli, txd);
--
2.47.3
Powered by blists - more mailing lists