linux-kernel - Re: [PATCH 1/3] ASoC: codecs: pm4125: drop bogus container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DF4GIFQ51LXM.243ZASZKP9NJ7@linaro.org>
Date: Mon, 22 Dec 2025 04:22:28 +0000
From: "Alexey Klimov" <alexey.klimov@...aro.org>
To: "Johan Hovold" <johan@...nel.org>, "Srinivas Kandagatla"
 <srini@...nel.org>, "Mark Brown" <broonie@...nel.org>
Cc: "Liam Girdwood" <lgirdwood@...il.com>, <linux-sound@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] ASoC: codecs: pm4125: drop bogus container_of()
 error handling

On Fri Dec 19, 2025 at 2:27 PM GMT, Johan Hovold wrote:
> The dev_to_sdw_dev() helper uses container_of() to return the containing
> soundwire device structure of its pointer argument and will never return
> NULL.
>
> Fixes: 8ad529484937 ("ASoC: codecs: add new pm4125 audio codec driver")
> Cc: Alexey Klimov <alexey.klimov@...aro.org>
> Signed-off-by: Johan Hovold <johan@...nel.org>

I was about to ask to check other drivers/codecs, most likely
wcd937x as one of the reference points to pm4125 codec,
but you already did. Thank you for checking this.

Acked-by: Alexey Klimov <alexey.klimov@...aro.org>

Best regards,
Alexey