linux-kernel - Re: [PATCH v2 5/5] selftests/mm: fix comment for check_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc3c5224-e012-426b-a66d-d4c7bd945bcf@redhat.com>
Date: Mon, 22 Dec 2025 14:37:19 -0500
From: Luiz Capitulino <luizcap@...hat.com>
To: Chunyu Hu <chuhu@...hat.com>, akpm@...ux-foundation.org,
 david@...nel.org, shuah@...nel.org, linux-mm@...ck.org
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
 rppt@...nel.org, surenb@...gle.com, mhocko@...e.com
Subject: Re: [PATCH v2 5/5] selftests/mm: fix comment for
 check_test_requirements

On 2025-12-20 23:00, Chunyu Hu wrote:
> The test supports arm64 as well so the comment is incorrect. And there's
> a check for arm64 in va_high_addr_switch.c.
> 
> CC: Luiz Capitulino <luizcap@...hat.com>
> Fixes: 983e760bcdb6 ("selftest/mm: va_high_addr_switch: add ppc64 support check")
> Fixes: f556acc2facd ("selftests/mm: skip test for non-LPA2 and non-LVA systems")
> Signed-off-by: Chunyu Hu <chuhu@...hat.com>

Reviewed-by: Luiz Capitulino <luizcap@...hat.com>

> ---
>   tools/testing/selftests/mm/va_high_addr_switch.sh | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh
> index a0c93d348b11..9492c2d72634 100755
> --- a/tools/testing/selftests/mm/va_high_addr_switch.sh
> +++ b/tools/testing/selftests/mm/va_high_addr_switch.sh
> @@ -61,9 +61,9 @@ check_supported_ppc64()
>   
>   check_test_requirements()
>   {
> -	# The test supports x86_64 and powerpc64. We currently have no useful
> -	# eligibility check for powerpc64, and the test itself will reject other
> -	# architectures.
> +	# The test supports x86_64, powerpc64 and arm64. There's check for arm64
> +	# in va_high_addr_switch.c. The test itself will reject other architectures.
> +
>   	case `uname -m` in
>   		"x86_64")
>   			check_supported_x86_64