linux-kernel - Re: [PATCH v2] module: Only declare set_module_sig_enforced when CONFIG_MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176643400584.1902051.10979216909918913544.b4-ty@google.com>
Date: Mon, 22 Dec 2025 20:24:14 +0000
From: Sami Tolvanen <samitolvanen@...gle.com>
To: linux-modules@...r.kernel.org, Coiby Xu <coxu@...hat.com>
Cc: Sami Tolvanen <samitolvanen@...gle.com>, linux-integrity@...r.kernel.org, 
	kernel test robot <lkp@...el.com>, Aaron Tomlin <atomlin@...mlin.com>, Daniel Gomez <da.gomez@...sung.com>, 
	Luis Chamberlain <mcgrof@...nel.org>, Petr Pavlu <petr.pavlu@...e.com>, 
	Daniel Gomez <da.gomez@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] module: Only declare set_module_sig_enforced when CONFIG_MODULE_SIG=y

On Mon, 01 Dec 2025 11:06:05 +0800, Coiby Xu wrote:
> Currently if set_module_sig_enforced is called with CONFIG_MODULE_SIG=n
> e.g. [1], it can lead to a linking error,
> 
>     ld: security/integrity/ima/ima_appraise.o: in function `ima_appraise_measurement':
>     security/integrity/ima/ima_appraise.c:587:(.text+0xbbb): undefined reference to `set_module_sig_enforced'
> 
> This happens because the actual implementation of
> set_module_sig_enforced comes from CONFIG_MODULE_SIG but both the
> function declaration and the empty stub definition are tied to
> CONFIG_MODULES.
> 
> [...]

Applied to modules-next, thanks!

[1/1] module: Only declare set_module_sig_enforced when CONFIG_MODULE_SIG=y
      commit: 1ae719a43b0336678172b3eb55c5187816f9a130

Best regards,

	Sami