linux-kernel - Re: [PATCH v1 16/23] hwspinlock: omap: Discard pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <o54twe6xkpqn35khexdj7sbdzsi7i7lsqo4h66y5l5dsymmvrv@uvjxuvpizdcm>
Date: Mon, 22 Dec 2025 14:46:25 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Linux PM <linux-pm@...r.kernel.org>, 
	LKML <linux-kernel@...r.kernel.org>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Brian Norris <briannorris@...omium.org>, Baolin Wang <baolin.wang@...ux.alibaba.com>, 
	linux-omap@...r.kernel.org, linux-remoteproc@...r.kernel.org
Subject: Re: [PATCH v1 16/23] hwspinlock: omap: Discard pm_runtime_put()
 return value

On Mon, Dec 22, 2025 at 09:24:19PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Failing driver probe due to pm_runtime_put() returning a negative value
> is not particularly useful.
> 
> Returning an error code from pm_runtime_put() merely means that it has
> not queued up a work item to check whether or not the device can be
> suspended and there are many perfectly valid situations in which that
> can happen, like after writing "on" to the devices' runtime PM "control"
> attribute in sysfs for one example.  It also happens when the kernel
> has been configured with CONFIG_PM unset.
> 
> Accordingly, update omap_hwspinlock_probe() to simply discard the
> return value of pm_runtime_put().
> 
> This will facilitate a planned change of the pm_runtime_put() return
> type to void in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Acked-by: Bjorn Andersson <andersson@...nel.org>

Regards,
Bjorn

> ---
> 
> This patch is part of a series, but it doesn't depend on anything else
> in that series.  The last patch in the series depends on it.
> 
> It can be applied by itself and if you decide to do so, please let me
> know.
> 
> Otherwise, an ACK or equivalent will be appreciated, but also the lack
> of specific criticism will be eventually regarded as consent.
> 
> ---
>  drivers/hwspinlock/omap_hwspinlock.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> --- a/drivers/hwspinlock/omap_hwspinlock.c
> +++ b/drivers/hwspinlock/omap_hwspinlock.c
> @@ -101,9 +101,7 @@ static int omap_hwspinlock_probe(struct
>  	 * runtime PM will make sure the clock of this module is
>  	 * enabled again iff at least one lock is requested
>  	 */
> -	ret = pm_runtime_put(&pdev->dev);
> -	if (ret < 0)
> -		return ret;
> +	pm_runtime_put(&pdev->dev);
>  
>  	/* one of the four lsb's must be set, and nothing else */
>  	if (hweight_long(i & 0xf) != 1 || i > 8)
> 
> 
>