linux-kernel - Re: [PATCH 0/4] usb: typec: ucsi: revert broken buffer management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6073f4f-edb3-470c-be63-4c3054d497a0@linux.intel.com>
Date: Mon, 22 Dec 2025 14:15:10 -0800
From: "Katiyar, Pooja" <pooja.katiyar@...ux.intel.com>
To: Johan Hovold <johan@...nel.org>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Pooja Katiyar <pooja.katiyar@...el.com>,
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] usb: typec: ucsi: revert broken buffer management

Hello Jonah,

On Mon, Dec 22, 2025 at 07:22:00AM -0800, Johan Hovold wrote:
> The new buffer management code has not been tested or reviewed properly
> and breaks boot of machines like the Lenovo ThinkPad X13s.
> 
> Fixing this will require designing a proper interface for managing these
> transactions, something which most likely involves reverting most of the
> offending commit anyway.
> 	    
> Revert the broken code to fix the regression and let Intel come up with
> a properly tested implementation for a later kernel.
> 

Thanks! A fix patch addressing the race condition has been identified and
is being tested right now. It will be submitted for review shortly.

Here’s the discussion on same - 
https://lore.kernel.org/all/349e1f70-7e40-4e3e-b078-6e001bbb5f1a@oss.qualcomm.com/

> Johan
> 
> 
> Johan Hovold (4):
>   Revert "usb: typec: ucsi: Add support for SET_PDOS command"
>   Revert "usb: typec: ucsi: Enable debugfs for message_out data
>     structure"
>   Revert "usb: typec: ucsi: Add support for message out data structure"
>   Revert "usb: typec: ucsi: Update UCSI structure to have message in and
>     message out fields"
> 
>  drivers/usb/typec/ucsi/cros_ec_ucsi.c   |   5 +-
>  drivers/usb/typec/ucsi/debugfs.c        |  36 +-------
>  drivers/usb/typec/ucsi/displayport.c    |  11 +--
>  drivers/usb/typec/ucsi/ucsi.c           | 118 ++++++++----------------
>  drivers/usb/typec/ucsi/ucsi.h           |  22 ++---
>  drivers/usb/typec/ucsi/ucsi_acpi.c      |  25 +----
>  drivers/usb/typec/ucsi/ucsi_ccg.c       |  11 ++-
>  drivers/usb/typec/ucsi/ucsi_yoga_c630.c |  15 +--
>  8 files changed, 71 insertions(+), 172 deletions(-)
> 

Regards,
Pooja