linux-kernel - Re: [PATCH v2 4/6] media: uvcvideo: Document how to format GUIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251222005634.GA5317@pendragon.ideasonboard.com>
Date: Mon, 22 Dec 2025 02:56:34 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: Hans de Goede <hansg@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 4/6] media: uvcvideo: Document how to format GUIDs

Hi Ricardo,

Thank you for the patch.

On Wed, Nov 19, 2025 at 07:37:13PM +0000, Ricardo Ribalda wrote:
> Manual formatting the GUIDs can lead to errors, document a
> programmatically way to format the GUIDs from lsusb into something tha

s/tha/that/

> the driver can use.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> ---
>  include/linux/usb/uvc.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/linux/usb/uvc.h b/include/linux/usb/uvc.h
> index b939a01da11466747249c64c72a3ea40cd364a59..dea23aabbad48270c807463c1a7e1c0d1b79fc1f 100644
> --- a/include/linux/usb/uvc.h
> +++ b/include/linux/usb/uvc.h
> @@ -10,6 +10,14 @@
>  
>  /* ------------------------------------------------------------------------
>   * GUIDs
> + *
> + * The GUID returned by lsusb can be converted to this format with the
> + * following python snippet:
> + *
> + * import uuid
> + * id = "{01234567-89ab-cdef-0123-456789abcdef}"
> + * le = uuid.UUID(id).bytes_le
> + * print("{" + ", ".join([f"0x{b:02x}" for b in le]) + "}")

Note that lsusb has changed the endianness of the printed GUID at some
point :-/ That was in 2017 though, so I think we can ignore the issue
now.

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

>   */
>  #define UVC_GUID_UVC_CAMERA \
>  	{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \

-- 
Regards,

Laurent Pinchart