linux-kernel - Re: [PATCH v16 15/17] rust: sync: lock/global: Add Backend parameter to GlobalGuard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DF4J677NSJDC.3QY743918HBOI@kernel.org>
Date: Mon, 22 Dec 2025 07:27:33 +0100
From: "Benno Lossin" <lossin@...nel.org>
To: "Lyude Paul" <lyude@...hat.com>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "Thomas Gleixner" <tglx@...utronix.de>
Cc: "Boqun Feng" <boqun.feng@...il.com>, "Daniel Almeida"
 <daniel.almeida@...labora.com>, "Miguel Ojeda" <ojeda@...nel.org>, "Alex
 Gaynor" <alex.gaynor@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "Danilo Krummrich" <dakr@...nel.org>,
 "Andrew Morton" <akpm@...ux-foundation.org>, "Peter Zijlstra"
 <peterz@...radead.org>, "Ingo Molnar" <mingo@...hat.com>, "Will Deacon"
 <will@...nel.org>, "Waiman Long" <longman@...hat.com>
Subject: Re: [PATCH v16 15/17] rust: sync: lock/global: Add Backend
 parameter to GlobalGuard

On Mon Dec 15, 2025 at 6:58 PM CET, Lyude Paul wrote:
> @@ -94,11 +94,11 @@ pub fn try_lock(&'static self) -> Option<GlobalGuard<'static, G>> {
>  /// A guard for a [`GlobalLock`].
>  ///
>  /// See [`global_lock!`] for examples.
> -pub struct GlobalGuard<'a, G: GlobalLockBackend> {
> -    inner: Guard<'a, G::Item, G::Backend>,
> +pub struct GlobalGuard<'a, G: GlobalLockBackend, B: Backend> {

Could be useful to make `B` have a default value of `G::Backend`?

Reviewed-by: Benno Lossin <lossin@...nel.org>

Cheers,
Benno

> +    inner: Guard<'a, G::Item, B>,
>  }
>  
> -impl<'a, G: GlobalLockBackend> core::ops::Deref for GlobalGuard<'a, G> {
> +impl<'a, G: GlobalLockBackend, B: Backend> core::ops::Deref for GlobalGuard<'a, G, B> {
>      type Target = G::Item;
>  
>      fn deref(&self) -> &Self::Target {