linux-kernel - Re: [PATCH] sparc/vdso: add missing prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251222083340-159edb10-2209-40af-9d7d-8959ac485a07@linutronix.de>
Date: Mon, 22 Dec 2025 08:36:12 +0100
From: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
	Andreas Larsson <andreas@...sler.com>, sparclinux@...r.kernel.org
Subject: Re: [PATCH] sparc/vdso: add missing prototypes

Hi Randy,

On Mon, Dec 08, 2025 at 09:03:32PM -0800, Randy Dunlap wrote:
> On sparc64, when CONFIG_WERROR=y, there are a few missing-prototype
> build errors. Fix them.
> 
> Add the 4 missing prototypes to <asm/vdso.h> and include that header
> file in vclock_gettime.c.
> 
> Fixes these build errors:
> In file included from ../arch/sparc/vdso/vdso32/vclock_gettime.c:22:
> ../arch/sparc/vdso/vdso32/../vclock_gettime.c:274:1: error: no previous
>  prototype for '__vdso_clock_gettime' [-Werror=missing-prototypes]
> ../arch/sparc/vdso/vdso32/../vclock_gettime.c:302:1: error: no previous
>  prototype for '__vdso_clock_gettime_stick' [-Werror=missing-prototypes]
> ../arch/sparc/vdso/vdso32/../vclock_gettime.c:327:1: error: no previous
>  prototype for '__vdso_gettimeofday' [-Werror=missing-prototypes]
> ../arch/sparc/vdso/vdso32/../vclock_gettime.c:363:1: error: no previous
>  prototype for '__vdso_gettimeofday_stick' [-Werror=missing-prototypes]

This issue would also be fixed by my patch series adopting the generic
vDSO library on SPARC [0].
Picking up your patch would introduce conflicts.

[0] https://lore.kernel.org/lkml/20251106-vdso-sparc64-generic-2-v5-0-97ff2b6542f7@linutronix.de/


Thomas