linux-kernel - Re: [PATCH][next] scsi: ufs: host: mediatek: make read-only array scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65daa0cefe5c09d138bdc545be23be9e58d7e762.camel@mediatek.com>
Date: Mon, 22 Dec 2025 08:13:00 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "chu.stanley@...il.com" <chu.stanley@...il.com>, "AngeloGioacchino Del
 Regno" <angelogioacchino.delregno@...labora.com>, "colin.i.king@...il.com"
	<colin.i.king@...il.com>, Chaotian Jing (井朝天)
	<Chaotian.Jing@...iatek.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>
CC: "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] scsi: ufs: host: mediatek: make read-only array
 scale_us static const

On Fri, 2025-12-19 at 21:44 +0000, Colin Ian King wrote:
> Don't populate the read-only array scale_us on the stack at run time,
> instead make it static const.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/ufs/host/ufs-mediatek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-
> mediatek.c
> index ecbbf52bf734..66b11cc0703b 100644
> --- a/drivers/ufs/host/ufs-mediatek.c
> +++ b/drivers/ufs/host/ufs-mediatek.c
> @@ -1112,7 +1112,7 @@ static void ufs_mtk_setup_clk_gating(struct
> ufs_hba *hba)
>         unsigned long flags;
>         u32 ah_ms = 10;
>         u32 ah_scale, ah_timer;
> -       u32 scale_us[] = {1, 10, 100, 1000, 10000, 100000};
> +       static const u32 scale_us[] = {1, 10, 100, 1000, 10000,
> 100000};
> 

Reviewed-by: Peter Wang <peter.wang@...iatek.com>