linux-kernel - Re: [PATCH 1/3] dt-bindings: i2c: qcom-cci: Document sm6150 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b96c10a5-942d-446e-b67e-a566a7d09274@oss.qualcomm.com>
Date: Mon, 22 Dec 2025 10:49:45 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Wenmeng Liu <wenmeng.liu@....qualcomm.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Loic Poulain <loic.poulain@....qualcomm.com>,
        Robert Foss
 <rfoss@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: i2c: qcom-cci: Document sm6150
 compatible

On 12/22/25 10:13 AM, Wenmeng Liu wrote:
> 
> 
> On 12/22/2025 4:58 PM, Krzysztof Kozlowski wrote:
>> On 22/12/2025 09:44, Wenmeng Liu wrote:
>>> Add the sm6150 CCI device string compatible.
>>>
>>> Signed-off-by: Wenmeng Liu <wenmeng.liu@....qualcomm.com>
>>> ---
>>>   .../devicetree/bindings/i2c/qcom,i2c-cci.yaml          | 18 ++++++++++++++++++
>>>   1 file changed, 18 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>> index a3fe1eea6aece9685674feaa5ec53765c1ce23d8..cb5e6fd5b2ad1de79a9b29d54869d093c952d778 100644
>>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>> @@ -33,6 +33,7 @@ properties:
>>>                 - qcom,sc8280xp-cci
>>>                 - qcom,sdm670-cci
>>>                 - qcom,sdm845-cci
>>> +              - qcom,sm6150-cci
>>>                 - qcom,sm6350-cci
>>>                 - qcom,sm8250-cci
>>>                 - qcom,sm8450-cci
>>> @@ -263,6 +264,23 @@ allOf:
>>>               - const: cpas_ahb
>>>               - const: cci
>>>   +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - qcom,sm6150-cci
>>> +    then:
>>> +      properties:
>>> +        clocks:
>>> +          minItems: 3
>>> +          maxItems: 3
>>> +        clock-names:
>>> +          items:
>>> +            - const: soc_ahb
>>
>>
>> Isn't this just camnoc_axi for this device (pay attention: to this device)?
>>
> 
> On this SOC, both soc_ahb and camnoc_axi exist.
> Is it suggested that I use the existing ones below?
>  - if:
>       properties:
>         compatible:
>           contains:
>             enum:
>               - qcom,sdm670-cci
>     then:
>       properties:
>         clocks:
>           minItems: 4
>           maxItems: 4
>         clock-names:
>           items:
>             - const: camnoc_axi
>             - const: soc_ahb
>             - const: cpas_ahb
>             - const: cci

Are both AXI and the two AHB clocks necessary for the CCI to operate?
It wasn't the case on other similarly-aged platforms

Konrad