Message-ID: <d7a749e2-1d00-459f-adbb-0841190b7849@kernel.org>
Date: Mon, 22 Dec 2025 10:53:31 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peter Griffin <peter.griffin@...aro.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 André Draszik <andre.draszik@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Sam Protsenko <semen.protsenko@...aro.org>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Will McVicker
 <willmcvicker@...gle.com>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 kernel-team@...roid.com
Subject: Re: [PATCH v6 1/4] dt-bindings: clock: google,gs101-clock: add
 samsung,sysreg property as required

On 22/12/2025 10:39, Peter Griffin wrote:
> Hi Krzysztof,
> 
> On Sun, 21 Dec 2025 at 13:26, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On 20/12/2025 10:05, Peter Griffin wrote:
>>> Each CMU (with the exception of cmu_top) has a corresponding sysreg bank
>>> that contains the BUSCOMPONENT_DRCG_EN and optional MEMCLK registers.
>>> The BUSCOMPONENT_DRCG_EN register enables dynamic root clock gating of
>>> bus components and MEMCLK gates the sram clock.
>>>
>>> Now the clock driver supports automatic clock mode, to fully enable dynamic
>>> root clock gating it is required to configure these registers. Update the
>>> bindings documentation so that all CMUs (with the exception of
>>> gs101-cmu-top) have samsung,sysreg as a required property.
>>>
>>> Note this is NOT an ABI break, as if the property isn't specified the
>>> clock driver will fallback to the current behaviour of not initializing
>>> the registers. The system still boots, but bus components won't benefit
>>> from dynamic root clock gating and dynamic power will be higher (which has
>>> been the case until now anyway).
>>>
>>> Additionally update the DT example to included the correct CMU size as
>>> registers in that region are used for automatic clock mode.
>>>
>>> Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
>>> ---
>>> Changes in v5:
>>> - Invert the test for google,gs101-cmu-top (Andre)
>>>
>>
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
>> of patchset, under or above your Signed-off-by tag, unless patch changed
>> significantly (e.g. new properties added to the DT bindings). Tag is
>> "received", when provided in a message replied to you on the mailing
>> list. Tools like b4 can help here. However, there's no need to repost
>> patches *only* to add the tags. The upstream maintainer will do that for
>> tags received on the version they apply.
>>
>> Please read:
>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>>
>> If a tag was not added on purpose, please state why and what changed.
>> </form letter>
> 
> Apologies, your tag should have been added.... got kind of sidetracked
> bisecting the linux-next regression with the serial console and then
> forgot to apply it.

I think it was more than one tag, so I decided not to look for them.
Please send v7 with all tags collected.

Best regards,
Krzysztof

Powered by blists - more mailing lists