linux-kernel - Re: [PATCH next] wifi: ath12k: clean up on error in ath12k_dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202512221824.sz1jZjhH-lkp@intel.com>
Date: Mon, 22 Dec 2025 18:25:04 +0800
From: kernel test robot <lkp@...el.com>
To: Dan Carpenter <error27@...il.com>,
	Harsh Kumar Bijlani <quic_hbijlani@...cinc.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Jeff Johnson <jjohnson@...nel.org>,
	Ripan Deuri <quic_rdeuri@...cinc.com>,
	Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@....qualcomm.com>,
	Baochen Qiang <baochen.qiang@....qualcomm.com>,
	linux-wireless@...r.kernel.org, ath12k@...ts.infradead.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] wifi: ath12k: clean up on error in ath12k_dp_setup()

Hi Dan,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20251217]

url:    https://github.com/intel-lab-lkp/linux/commits/Dan-Carpenter/wifi-ath12k-clean-up-on-error-in-ath12k_dp_setup/20251218-154554
base:   next-20251217
patch link:    https://lore.kernel.org/r/aUOw1J0TU4VgeXj6%40stanley.mountain
patch subject: [PATCH next] wifi: ath12k: clean up on error in ath12k_dp_setup()
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20251222/202512221824.sz1jZjhH-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251222/202512221824.sz1jZjhH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512221824.sz1jZjhH-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/wireless/ath/ath12k/dp.c:1767:8: error: use of undeclared label 'rhash_destroy'
                   goto rhash_destroy;
                        ^
   1 error generated.


vim +/rhash_destroy +1767 drivers/net/wireless/ath/ath12k/dp.c

  1734	
  1735	int ath12k_dp_alloc(struct ath12k_base *ab)
  1736	{
  1737		struct ath12k_dp *dp = &ab->dp;
  1738		struct hal_srng *srng = NULL;
  1739		size_t size = 0;
  1740		u32 n_link_desc = 0;
  1741		int ret;
  1742		int i;
  1743	
  1744		dp->ab = ab;
  1745	
  1746		INIT_LIST_HEAD(&dp->reo_cmd_list);
  1747		INIT_LIST_HEAD(&dp->reo_cmd_cache_flush_list);
  1748		INIT_LIST_HEAD(&dp->reo_cmd_update_rx_queue_list);
  1749		spin_lock_init(&dp->reo_cmd_lock);
  1750		spin_lock_init(&dp->reo_rxq_flush_lock);
  1751	
  1752		dp->reo_cmd_cache_flush_count = 0;
  1753		dp->idle_link_rbm = ath12k_dp_get_idle_link_rbm(ab);
  1754	
  1755		ret = ath12k_wbm_idle_ring_setup(ab, &n_link_desc);
  1756		if (ret) {
  1757			ath12k_warn(ab, "failed to setup wbm_idle_ring: %d\n", ret);
  1758			return ret;
  1759		}
  1760	
  1761		srng = &ab->hal.srng_list[dp->wbm_idle_ring.ring_id];
  1762	
  1763		ret = ath12k_dp_link_desc_setup(ab, dp->link_desc_banks,
  1764						HAL_WBM_IDLE_LINK, srng, n_link_desc);
  1765		if (ret) {
  1766			ath12k_warn(ab, "failed to setup link desc: %d\n", ret);
> 1767			goto rhash_destroy;

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki