linux-kernel - Re: [PATCH iwlwifi-fixes] wifi: iwlwifi: Implement settime64 as stub for MVM/MLD PTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9280406b-d21a-47e7-a404-f494a0419431@redhat.com>
Date: Mon, 22 Dec 2025 11:43:39 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Johannes Berg <johannes.berg@...el.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, Mingcong Bai <jeffbai@...c.io>,
 Kexy Biscuit <kexybiscuit@...c.io>, Nathan Chancellor <nathan@...nel.org>,
 Yao Zi <ziyao@...root.org>, Richard Cochran <richardcochran@...il.com>,
 Miri Korenblit <miriam.rachel.korenblit@...el.com>,
 Anjaneyulu <pagadala.yesu.anjaneyulu@...el.com>,
 Daniel Gabay <daniel.gabay@...el.com>
Subject: Re: [PATCH iwlwifi-fixes] wifi: iwlwifi: Implement settime64 as stub
 for MVM/MLD PTP

On 12/4/25 1:32 PM, Yao Zi wrote:
> Since commit dfb073d32cac ("ptp: Return -EINVAL on ptp_clock_register if
> required ops are NULL"), PTP clock registered through ptp_clock_register
> is required to have ptp_clock_info.settime64 set, however, neither MVM
> nor MLD's PTP clock implementation sets it, resulting in warnings when
> the interface starts up, like
> 
> WARNING: drivers/ptp/ptp_clock.c:325 at ptp_clock_register+0x2c8/0x6b8, CPU#1: wpa_supplicant/469
> CPU: 1 UID: 0 PID: 469 Comm: wpa_supplicant Not tainted 6.18.0+ #101 PREEMPT(full)
> ra: ffff800002732cd4 iwl_mvm_ptp_init+0x114/0x188 [iwlmvm]
> ERA: 9000000002fdc468 ptp_clock_register+0x2c8/0x6b8
> iwlwifi 0000:01:00.0: Failed to register PHC clock (-22)
> 
> I don't find an appropriate firmware interface to implement settime64()
> for iwlwifi MLD/MVM, thus instead create a stub that returns
> -EOPTNOTSUPP only, suppressing the warning and allowing the PTP clock to
> be registered.
> 
> Reported-by: Nathan Chancellor <nathan@...nel.org>
> Closes: https://lore.kernel.org/all/20251108044822.GA3262936@ax162/
> Signed-off-by: Yao Zi <ziyao@...root.org>

@Johannes: I think this patch is already in your tree, if so, can you
please share a PR with it? there are a few notable users hit by such
warning:

https://lore.kernel.org/
netdev/221ba5ce-8652-4bc4-8d4a-6fc379e32ef8@...tkopp.net/T/
#m3e671c8c9a482d90a6fa81e953af723af5546118

Otherwise I could directly apply the patch to 'net' before the next PR
to Linus (on ~30 Dec).

Please LMK!

Thanks,

Paolo