linux-kernel - Re: [PATCH] irqchip/gic-v5: Fix gicv5_its_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86o6nqn6fo.wl-maz@kernel.org>
Date: Mon, 22 Dec 2025 10:42:51 +0000
From: Marc Zyngier <maz@...nel.org>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	kernel test robot <lkp@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] irqchip/gic-v5: Fix gicv5_its_map_event() ITTE read endianness

On Mon, 22 Dec 2025 10:22:50 +0000,
Lorenzo Pieralisi <lpieralisi@...nel.org> wrote:
> 
> Kbuild bot (through sparse) reported that the ITTE read to carry out
> a valid check in gicv5_its_map_event() lacks proper endianness handling.
> 
> Fix it.
> 
> Fixes: 57d72196dfc8 ("irqchip/gic-v5: Add GICv5 ITS support")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512131849.30ZRTBeR-lkp@intel.com/
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Marc Zyngier <maz@...nel.org>
> ---
>  drivers/irqchip/irq-gic-v5-its.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
> index 554485f0be1f..8e22134b9f48 100644
> --- a/drivers/irqchip/irq-gic-v5-its.c
> +++ b/drivers/irqchip/irq-gic-v5-its.c
> @@ -849,7 +849,7 @@ static int gicv5_its_map_event(struct gicv5_its_dev *its_dev, u16 event_id, u32
>  
>  	itte = gicv5_its_device_get_itte_ref(its_dev, event_id);
>  
> -	if (FIELD_GET(GICV5_ITTL2E_VALID, *itte))
> +	if (FIELD_GET(GICV5_ITTL2E_VALID, le64_to_cpu(*itte)))
>  		return -EEXIST;
>  
>  	itt_entry = FIELD_PREP(GICV5_ITTL2E_LPI_ID, lpi) |

Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.