linux-kernel - Re: [PATCH] s390/cmm: Use max to simplify cmm_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251222105726.16440Adf-hca@linux.ibm.com>
Date: Mon, 22 Dec 2025 11:57:26 +0100
From: Heiko Carstens <hca@...ux.ibm.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Alexander Gordeev <agordeev@...ux.ibm.com>,
        Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/cmm: Use max to simplify cmm_timer_fn

Thorsten,

On Mon, Dec 22, 2025 at 11:39:17AM +0100, Thorsten Blum wrote:
> Use max() to replace the open-coded version and simplify cmm_timer_fn().
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  arch/s390/mm/cmm.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

...

>  	nr = cmm_timed_pages_target - cmm_timeout_pages;
> -	if (nr < 0)
> -		cmm_timed_pages_target = 0;
> -	else
> -		cmm_timed_pages_target = nr;
> +	cmm_timed_pages_target = max(0, nr);

Just in case it wasn't clear in the past: trivial patches like this won't be
taken. You already managed to send buggy patches which look trivial, and I'm
not willing to spend time to look for subtle bugs such trivial patches might
introduce.

In other words: you may stop sending such patches which address s390 code.