| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <703a502c-883d-434a-8bcf-f785080f5102@oss.qualcomm.com>
Date: Mon, 22 Dec 2025 19:41:22 +0800
From: Wenmeng Liu <wenmeng.liu@....qualcomm.com>
To: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
Loic Poulain <loic.poulain@....qualcomm.com>,
Robert Foss
<rfoss@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, linux-i2c@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: talos-evk-camera: Add DT overlay
On 12/22/2025 7:19 PM, Vladimir Zapolskiy wrote:
> On 12/22/25 10:44, Wenmeng Liu wrote:
>> Enable IMX577 via CCI on Taloss EVK Core Kit.
>>
>> The Talos EVK board does not include a camera sensor
>> by default, this overlay reflects the possibility of
>> attaching an optional camera sensor.
>> For this reason, the camera sensor configuration is
>> placed in talos-evk-camera.dtso, rather than
>> modifying the base talos-evk.dts.
>>
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@....qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 2 +
>> arch/arm64/boot/dts/qcom/talos-evk-camera.dtso | 64 ++++++++++++++++
>> ++++++++++
>> arch/arm64/boot/dts/qcom/talos.dtsi | 21 +++++++++
>
> Please split QCS615 MCLK definitions change into a separate commit.
ACK.>
>> 3 files changed, 87 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/
>> qcom/Makefile
>> index
>> 60121f133078b2754f98e6f45a3db4031b478cc8..b1d85b1f4a94714f2a5c976d162482d70ae920f2 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -325,7 +325,9 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb
>> +talos-evk-camera-dtbs := talos-evk.dtb talos-evk-camera.dtbo
>> talos-evk-lvds-auo,g133han01-dtbs := talos-evk.dtb talos-evk-
>> lvds-auo,g133han01.dtbo
>> +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-camera.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += talos-evk-lvds-auo,g133han01.dtb
>> x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo
>> dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-
>> el2.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-camera.dtso b/arch/
>> arm64/boot/dts/qcom/talos-evk-camera.dtso
>> new file mode 100644
>> index
>> 0000000000000000000000000000000000000000..ae1a02295b4dc48212aad40980a329ff458fe69a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/talos-evk-camera.dtso
>> @@ -0,0 +1,64 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>
> Please add a missing year of the change.
Now our requirement is a yearless copyright.>
>> + */
>> +
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +#include <dt-bindings/clock/qcom,qcs615-camcc.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +&camss {
>> + vdd-csiphy-1p2-supply = <&vreg_l11a>;
>> + vdd-csiphy-1p8-supply = <&vreg_l12a>;
>> +
>> + status = "okay";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@1 {
>> + reg = <1>;
>> +
>> + csiphy1_ep: endpoint {
>> + clock-lanes = <7>;
>
> Please remove 'clock-lanes' property.
ACK.>
>> + data-lanes = <0 1 2 3>;
>> + remote-endpoint = <&imx577_ep1>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&cci {
>> + status = "okay";
>> +};
>> +
>> +&cci_i2c1 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + camera@1a {
>> + compatible = "sony,imx577";
>> + reg = <0x1a>;
>> +
>> + reset-gpios = <&tlmm 29 GPIO_ACTIVE_LOW>;
>> + pinctrl-0 = <&cam2_default>;
>> + pinctrl-names = "default";
>> +
>> + clocks = <&camcc CAM_CC_MCLK2_CLK>;
>> + assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>;
>> + assigned-clock-rates = <24000000>;
>> +
>> + avdd-supply = <&vreg_s4a>;
>
> Just one voltage supply?
yes, 22pin camera module only have one pin for power.>
>> +
>> + port {
>> + imx577_ep1: endpoint {
>> + link-frequencies = /bits/ 64 <600000000>;
>> + data-lanes = <1 2 3 4>;
>> + remote-endpoint = <&csiphy1_ep>;
>> + };
>> + };
>> + };
>> +};
>> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/
>> dts/qcom/talos.dtsi
>> index
>> ebb1807f0222c075d4207163ed4359a55616d903..3626312f138f2e8f1888eb6aa43fa474cdee884f 100644
>> --- a/arch/arm64/boot/dts/qcom/talos.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi
>> @@ -1550,6 +1550,27 @@ tlmm: pinctrl@...0000 {
>> #interrupt-cells = <2>;
>> wakeup-parent = <&pdc>;
>> + cam0_default: cam0-default-state {
>> + pins = "gpio28";
>> + function = "cam_mclk";
>> + drive-strength = <2>;
>> + bias-disable;
>> + };
>> +
>> + cam1_default: cam1-default-state {
>> + pins = "gpio29";
>> + function = "cam_mclk";
>> + drive-strength = <2>;
>> + bias-disable;
>> + };
>> +
>> + cam2_default: cam2-default-state {
>> + pins = "gpio30";
>> + function = "cam_mclk";
>> + drive-strength = <2>;
>> + bias-disable;
>> + };
>> +
>
> Please add to the list another pad with MCLK function, which is GPIO31.
ACK.>
>> cci_default: cci0-default-state {
>> cci_i2c0_default: cci-i2c0-default-pins {
>> /* SDA, SCL */
>>
>
will update in next version.
Thanks,
Wenmeng
Powered by blists - more mailing lists