linux-kernel - RE: [PATCH] hid: intel-thc-hid: Select SGL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251222025535.1879559-1-even.xu@intel.com>
Date: Mon, 22 Dec 2025 10:55:35 +0800
From: Even Xu <even.xu@...el.com>
To: tim@...ux4.de
Cc: bentiss@...nel.org,
	even.xu@...el.com,
	jikos@...nel.org,
	linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	xinpeng.sun@...el.com
Subject: RE: [PATCH] hid: intel-thc-hid: Select SGL_ALLOC

From: "Xu, Even" <even.xu@...el.com>

> From: Tim Zimmermann <tim@...ux4.de>
> Cc: tim@...ux4.de, Even Xu <even.xu@...el.com>,
> 	Xinpeng Sun <xinpeng.sun@...el.com>,
> 	Jiri Kosina <jikos@...nel.org>,
> 	Benjamin Tissoires <bentiss@...nel.org>,
> 	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
> Subject: [PATCH] hid: intel-thc-hid: Select SGL_ALLOC
> Date: Fri, 28 Nov 2025 08:54:22 +0100	[thread overview]
> Message-ID: <20251128075426.628500-1-tim@...ux4.de> (raw)
> 
> intel-thc-dma.c uses sgl_alloc() resulting in a build failure if CONFIG_SGL_ALLOC is not enabled
> 
> Signed-off-by: Tim Zimmermann <tim@...ux4.de>
> ---
>  drivers/hid/intel-thc-hid/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/intel-thc-hid/Kconfig b/drivers/hid/intel-thc-hid/Kconfig
> index 0351d1137607..9d74e53b8c62 100644
> --- a/drivers/hid/intel-thc-hid/Kconfig
> +++ b/drivers/hid/intel-thc-hid/Kconfig
> @@ -7,6 +7,7 @@ menu "Intel THC HID Support"
>  config INTEL_THC_HID
>  	tristate "Intel Touch Host Controller"
>  	depends on ACPI
> +	select SGL_ALLOC
>  	help
>  	  THC (Touch Host Controller) is the name of the IP block in PCH that
>  	  interfaces with Touch Devices (ex: touchscreen, touchpad etc.). It

Thanks for the patch!

Reviewed-by: Even Xu <even.xu@...el.com>

> -- 
> 2.51.0