linux-kernel - Re: [PATCH v2] arm64: dts: rockchip: enable UFS controller on FriendlyElec NanoPi M5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <119070978.nniJfEyVGO@phil>
Date: Mon, 22 Dec 2025 13:41:43 +0100
From: Heiko Stuebner <heiko@...ech.de>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alexey Charkov <alchark@...il.com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH v2] arm64: dts: rockchip: enable UFS controller on FriendlyElec
 NanoPi M5

Hi Alexey,

Am Donnerstag, 18. Dezember 2025, 15:05:39 Mitteleuropäische Normalzeit schrieb Alexey Charkov:
> Hi Heiko,
> 
> On Mon, Dec 1, 2025 at 3:35 PM Alexey Charkov <alchark@...il.com> wrote:
> >
> > The NanoPi M5 board supports pluggable UFS modules using the UFSHC
> > inside its Rockchip RK3576 SoC.
> >
> > Enable the respective devicetree node and add its supply regulators.
> >
> > Link: https://wiki.friendlyelec.com/wiki/images/9/97/NanoPi_M5_LP5_2411_SCH.pdf
> > Signed-off-by: Alexey Charkov <alchark@...il.com>
> > ---
> > Changes in v2:
> > - Describe UFS supply regulators
> > - Add link to schematic
> > - Link to v1: https://lore.kernel.org/r/20251127-nanopi-m5-ufs-v1-1-0d28d157712c@gmail.com
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts | 27 +++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> 
> Would you mind pulling this one, or do you have any reservations?
> There hasn't been any discussion, but it looks like a pretty simple
> change, runtime tested and schema-tested.

Your patch fell directly into the dead-zone between -rc7 and -rc1 ;-)

> +	vcc1v2_ufs_vccq: regulator-vcc1v2-ufs-vccq {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <1200000>;
> +		regulator-max-microvolt = <1200000>;
> +		regulator-name = "vcc1v2_ufs_vccq";
> +		vin-supply = <&vcc5v0_sys_s5>;
> +		en-supply = <&vcc_3v3_s3>;
> +	};
> +
> +	vcc1v8_ufs_vccq2: regulator-vcc1v8-ufs-vccq2 {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-name = "vcc1v8_ufs_vccq2";
> +		vin-supply = <&vcc_1v8_s3>;
> +		en-supply = <&vdda_1v2_s0>;
> +	};


But where does the "en-supply" come from? For the life of me, I can't find
any reference to it in either the bindings in the kernel, nor the dt-schema.

Can you please point me to the part of the documentation where that is
described?

Thanks
Heiko