linux-kernel - Re: [PATCH v10 5/6] cadence: cdns-mhdp8546*: Change drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b0388de-0290-43b5-8c9b-162d9083af08@ideasonboard.com>
Date: Mon, 22 Dec 2025 15:02:36 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Harikrishna Shenoy <h-shenoy@...com>
Cc: Laurent.pinchart@...asonboard.com, airlied@...il.com,
 andrzej.hajda@...el.com, andy.yan@...k-chips.com, aradhya.bhatia@...ux.dev,
 devarsht@...com, dianders@...omium.org, dri-devel@...ts.freedesktop.org,
 javierm@...hat.com, jernej.skrabec@...il.com, jonas@...boo.se,
 linux-kernel@...r.kernel.org, linux@...blig.org, luca.ceresoli@...tlin.com,
 lumag@...nel.org, lyude@...hat.com, maarten.lankhorst@...ux.intel.com,
 mordan@...ras.ru, mripard@...nel.org, neil.armstrong@...aro.org,
 rfoss@...nel.org, s-jain1@...com, simona@...ll.ch, tzimmermann@...e.de,
 u-kumar1@...com
Subject: Re: [PATCH v10 5/6] cadence: cdns-mhdp8546*: Change drm_connector
 from structure to pointer

Hi,

On 09/12/2025 14:03, Harikrishna Shenoy wrote:
> From: Jayesh Choudhary <j-choudhary@...com>
> 
> Now that we have dropped the legacy code which became redundant with
> introduction of DRM_BRIDGE_ATTACH_NO_CONNECTOR
> usecase in driver,we can cleanly switch to drm_connector pointer
> instead of structure.
> 
> Rename the connector_ptr member variable to connector for clarity and
> consistency. The driver was using both connector and connector_ptr members,
> but connector_ptr was the only one actually used throughout the code.
> This change removes the unused connector struct member and renames
> connector_ptr to connector for better readability.
> 
> This is purely a code cleanup change with no functional impact. All
> references to connector_ptr are updated to use the renamed connector
> variable throughout the driver.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> Signed-off-by: Harikrishna Shenoy <h-shenoy@...com>
> ---
>  .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c    | 14 +++++++-------
>  .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.h    |  3 +--
>  .../gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c    | 12 ++++++------
>  3 files changed, 14 insertions(+), 15 deletions(-)

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

 Tomi