linux-kernel - Re: [PATCH] samples: rust: pci: replace `kernel::c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6D6C7BE4-164A-4E0A-A979-00EBB1F9C75A@collabora.com>
Date: Mon, 22 Dec 2025 11:24:27 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Tamir Duberstein <tamird@...nel.org>
Cc: Danilo Krummrich <dakr@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 linux-pci@...r.kernel.org,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Tamir Duberstein <tamird@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] samples: rust: pci: replace `kernel::c_str!` with
 C-Strings



> On 22 Dec 2025, at 09:23, Tamir Duberstein <tamird@...nel.org> wrote:
> 
> From: Tamir Duberstein <tamird@...il.com>
> 
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
> 
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> Reviewed-by: Benno Lossin <lossin@...nel.org>
> Acked-by: Danilo Krummrich <dakr@...nel.org>
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
> samples/rust/rust_driver_pci.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/samples/rust/rust_driver_pci.rs b/samples/rust/rust_driver_pci.rs
> index 5823787bea8e..991cc111fd63 100644
> --- a/samples/rust/rust_driver_pci.rs
> +++ b/samples/rust/rust_driver_pci.rs
> @@ -4,7 +4,7 @@
> //!
> //! To make this driver probe, QEMU must be run with `-device pci-testdev`.
> 
> -use kernel::{c_str, device::Core, devres::Devres, pci, prelude::*, sync::aref::ARef};
> +use kernel::{device::Core, devres::Devres, pci, prelude::*, sync::aref::ARef};
> 
> struct Regs;
> 
> @@ -79,7 +79,7 @@ fn probe(pdev: &pci::Device<Core>, info: &Self::IdInfo) -> impl PinInit<Self, Er
>             pdev.set_master();
> 
>             Ok(try_pin_init!(Self {
> -                bar <- pdev.iomap_region_sized::<{ Regs::END }>(0, c_str!("rust_driver_pci")),
> +                bar <- pdev.iomap_region_sized::<{ Regs::END }>(0, c"rust_driver_pci"),
>                 index: *info,
>                 _: {
>                     let bar = bar.access(pdev.as_ref())?;
> 
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251222-cstr-pci-448ca1f4aa31
> 
> Best regards,
> --  
> Tamir Duberstein <tamird@...il.com>
> 
> 

Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>