linux-kernel - Re: [PATCH] rust_binder: replace `kernel::c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <40D8A5A2-EED9-4E4A-97FE-0C4E3EF2784F@collabora.com>
Date: Mon, 22 Dec 2025 11:26:03 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Tamir Duberstein <tamird@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Arve Hjønnevåg <arve@...roid.com>,
 Todd Kjos <tkjos@...roid.com>,
 Christian Brauner <brauner@...nel.org>,
 Carlos Llamas <cmllamas@...gle.com>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Miguel Ojeda <ojeda@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Trevor Gross <tmgross@...ch.edu>,
 Danilo Krummrich <dakr@...nel.org>,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org,
 Tamir Duberstein <tamird@...il.com>
Subject: Re: [PATCH] rust_binder: replace `kernel::c_str!` with C-Strings



> On 22 Dec 2025, at 09:22, Tamir Duberstein <tamird@...nel.org> wrote:
> 
> From: Tamir Duberstein <tamird@...il.com>
> 
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
> 
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
> drivers/android/binder/rust_binder_main.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
> index c79a9e742240..519bc2fb310d 100644
> --- a/drivers/android/binder/rust_binder_main.rs
> +++ b/drivers/android/binder/rust_binder_main.rs
> @@ -288,7 +288,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result<Self> {
> 
>         pr_warn!("Loaded Rust Binder.");
> 
> -        BINDER_SHRINKER.register(kernel::c_str!("android-binder"))?;
> +        BINDER_SHRINKER.register(c"android-binder")?;
> 
>         // SAFETY: The module is being loaded, so we can initialize binderfs.
>         unsafe { kernel::error::to_result(binderfs::init_rust_binderfs())? };
> 
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251222-cstr-staging-e96cbee7d73e
> 
> Best regards,
> --  
> Tamir Duberstein <tamird@...il.com>
> 
> 

Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>