linux-kernel - Re: [PATCH] rust: regulator: replace `kernel::c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1B3A437A-5A9E-4109-A202-CD3172596929@collabora.com>
Date: Mon, 22 Dec 2025 11:35:35 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Tamir Duberstein <tamird@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Danilo Krummrich <dakr@...nel.org>,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org,
 Tamir Duberstein <tamird@...il.com>
Subject: Re: [PATCH] rust: regulator: replace `kernel::c_str!` with C-Strings



> On 22 Dec 2025, at 09:15, Tamir Duberstein <tamird@...nel.org> wrote:
> 
> From: Tamir Duberstein <tamird@...il.com>
> 
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
> 
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
> rust/kernel/regulator.rs | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/rust/kernel/regulator.rs b/rust/kernel/regulator.rs
> index 2c44827ad0b7..4f7837c7e53a 100644
> --- a/rust/kernel/regulator.rs
> +++ b/rust/kernel/regulator.rs
> @@ -122,12 +122,11 @@ pub fn devm_enable_optional(dev: &Device<Bound>, name: &CStr) -> Result {
> ///
> /// ```
> /// # use kernel::prelude::*;
> -/// # use kernel::c_str;
> /// # use kernel::device::Device;
> /// # use kernel::regulator::{Voltage, Regulator, Disabled, Enabled};
> /// fn enable(dev: &Device, min_voltage: Voltage, max_voltage: Voltage) -> Result {
> ///     // Obtain a reference to a (fictitious) regulator.
> -///     let regulator: Regulator<Disabled> = Regulator::<Disabled>::get(dev, c_str!("vcc"))?;
> +///     let regulator: Regulator<Disabled> = Regulator::<Disabled>::get(dev, c"vcc")?;
> ///
> ///     // The voltage can be set before enabling the regulator if needed, e.g.:
> ///     regulator.set_voltage(min_voltage, max_voltage)?;
> @@ -166,12 +165,11 @@ pub fn devm_enable_optional(dev: &Device<Bound>, name: &CStr) -> Result {
> ///
> /// ```
> /// # use kernel::prelude::*;
> -/// # use kernel::c_str;
> /// # use kernel::device::Device;
> /// # use kernel::regulator::{Voltage, Regulator, Enabled};
> /// fn enable(dev: &Device) -> Result {
> ///     // Obtain a reference to a (fictitious) regulator and enable it.
> -///     let regulator: Regulator<Enabled> = Regulator::<Enabled>::get(dev, c_str!("vcc"))?;
> +///     let regulator: Regulator<Enabled> = Regulator::<Enabled>::get(dev, c"vcc")?;
> ///
> ///     // Dropping an enabled regulator will disable it. The refcount will be
> ///     // decremented.
> @@ -193,13 +191,12 @@ pub fn devm_enable_optional(dev: &Device<Bound>, name: &CStr) -> Result {
> ///
> /// ```
> /// # use kernel::prelude::*;
> -/// # use kernel::c_str;
> /// # use kernel::device::{Bound, Device};
> /// # use kernel::regulator;
> /// fn enable(dev: &Device<Bound>) -> Result {
> ///     // Obtain a reference to a (fictitious) regulator and enable it. This
> ///     // call only returns whether the operation succeeded.
> -///     regulator::devm_enable(dev, c_str!("vcc"))?;
> +///     regulator::devm_enable(dev, c"vcc")?;
> ///
> ///     // The regulator will be disabled and put when `dev` is unbound.
> ///     Ok(())
> 
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251222-cstr-regulator-dc3f6d3fc384
> 
> Best regards,
> --  
> Tamir Duberstein <tamird@...il.com>
> 
> 

Reviewed-by: Daniel Almeida <Daniel.almeida@...labora.com>