linux-kernel - Re: [PATCH] lib/tests: convert test_min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHMDPKV-LMi2p3e-5HfbznaUKApR+jj_GkRMopq+D+ZmG5qy9g@mail.gmail.com>
Date: Tue, 23 Dec 2025 00:42:11 +0900
From: Ryota Sakamoto <sakamo.ryota@...il.com>
To: Kuan-Wei Chiu <visitorckw@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Geert Uytterhoeven <geert@...ux-m68k.org>, 
	Madhavan Srinivasan <maddy@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>, 
	Nicholas Piggin <npiggin@...il.com>, Christophe Leroy <chleroy@...nel.org>, 
	Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, 
	Alexander Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, 
	Sven Schnelle <svens@...ux.ibm.com>, David Gow <davidgow@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/tests: convert test_min_heap module to KUnit

Hi Kuan-Wei,

On Mon, Dec 22, 2025 at 12:50 PM Kuan-Wei Chiu <visitorckw@...il.com> wrote:
> While the change itself looks good, the commit message focuses heavily
> on *what* the patch does. I would prefer to see an explanation of *why*
> this patch is needed. Specifically, what are the benefits of converting
> to kunit compared to the original implementation?

You are right. In the original commit message, I focused on what we
did, not why we did.
The reasons for converting to KUnit are:
1. Standardization:
    Switching from ad-hoc printk-based reporting to the standard KTAP
format makes
    it easier for CI systems to parse and report test results
2. Better Diagnostics:
    Using KUNIT_EXPECT_* macros automatically provides detailed
diagnostics on failure.
3. Tooling Integration:
    It allows the test to be managed and executed using standard KUnit tools.

Hi Andrew,

Since this patch is already in your mm-nonmm-unstable tree, would you
prefer me to send
a v2 patch with the updated commit message, or could you kindly fold
these explanations
into the commit log?

Best regards,
Ryota Sakamoto