linux-kernel - Re: [PATCH v2 0/2] spi: cadence-quadspi: Prevent indirect read timeouts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176650963782.445653.10248419661863551247.b4-ty@kernel.org>
Date: Tue, 23 Dec 2025 17:07:17 +0000
From: Mark Brown <broonie@...nel.org>
To: Mateusz Litwin <mateusz.litwin@...ia.com>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] spi: cadence-quadspi: Prevent indirect read
 timeouts

On Thu, 18 Dec 2025 22:33:03 +0100, Mateusz Litwin wrote:
> On the Stratix10 platform, indirect reads can become very slow due to lost
> interrupts and/or missed `complete()` calls, causing
> `wait_for_completion_timeout()` to expire.
> 
> Three issues were identified:
> 1) A race condition exists between the read loop and IRQ `complete()`
>    call:
>    An IRQ can call `complete()` after the inner loop ends, but before
>    `reinit_completion()`, losing the completion event and leading to
>    `wait_for_completion_timeout()` expire. This function will not return
>    an error because `bytes_to_read` > 0 (indicating data is already in the
>    FIFO) and the final `ret` value is overwritten by
>    `cqspi_wait_for_bit()` return value (indicating request completion),
>    masking the timeout.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: cadence-quadspi: Prevent lost complete() call during indirect read
      commit: d67396c9d697041b385d70ff2fd59cb07ae167e8
[2/2] spi: cadence-quadspi: Improve CQSPI_SLOW_SRAM quirk if flash is slow
      commit: 5bfbbf0a49ee4b5dcf46a3bfd4cd860d72cc887d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark