linux-kernel - RE: [PATCH v2] mtd: spi-nor: micron-st: add SNOR_CMD_PP_8_8_8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB9496ED0C1AA219CEFA574D7F90B5A@DU0PR04MB9496.eurprd04.prod.outlook.com>
Date: Tue, 23 Dec 2025 02:01:30 +0000
From: Bough Chen <haibo.chen@....com>
To: Pratyush Yadav <pratyush@...nel.org>
CC: Tudor Ambarus <tudor.ambarus@...aro.org>, Michael Walle
	<mwalle@...nel.org>, Miquel Raynal <miquel.raynal@...tlin.com>, Richard
 Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Han Xu
	<han.xu@....com>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH v2] mtd: spi-nor: micron-st: add SNOR_CMD_PP_8_8_8_DTR
 sfdp fixup for mt35xu512aba

> -----Original Message-----
> From: Pratyush Yadav <pratyush@...nel.org>
> Sent: 2025年12月22日 23:40
> To: Bough Chen <haibo.chen@....com>
> Cc: Tudor Ambarus <tudor.ambarus@...aro.org>; Pratyush Yadav
> <pratyush@...nel.org>; Michael Walle <mwalle@...nel.org>; Miquel Raynal
> <miquel.raynal@...tlin.com>; Richard Weinberger <richard@....at>; Vignesh
> Raghavendra <vigneshr@...com>; linux-mtd@...ts.infradead.org;
> linux-kernel@...r.kernel.org; Han Xu <han.xu@....com>; imx@...ts.linux.dev
> Subject: Re: [PATCH v2] mtd: spi-nor: micron-st: add
> SNOR_CMD_PP_8_8_8_DTR sfdp fixup for mt35xu512aba
> 
> On Mon, Dec 15 2025, Haibo Chen wrote:
> 
> > Find two batches mt35xu512aba has different SFDP but with same jedec
> > ID. The batch which use the new version of SFDP contain all the
> > necessary information to support OCT DTR mode. The batch with old
> > version do not contain the OCT DTR command information, but in fact it
> > did support OCT DTR mode.
> >
> > Current mt35xu512aba_post_sfdp_fixup() add some setting including
> > SNOR_CMD_READ_8_8_8_DTR, but still lack SNOR_CMD_PP_8_8_8_DTR.
> Meet
> > issue on the batch mt35xu512aba with old SFDP version. Because no
> > SNOR_CMD_PP_8_8_8_DTR, micron_st_nor_octal_dtr_en() will not be
> > called, then use SNOR_CMD_READ_8_8_8_DTR will meet issue.
> >
> > Fixes: 44dd635cd632 ("mtd: spi-nor: micron-st: use SFDP of
> > mt35xu512aba")
> > Signed-off-by: Haibo Chen <haibo.chen@....com>
> > ---
> > Changes in v2:
> > - add 8D pp command in post sfdp fix up for the chip with old SFDP
> > - Link to v1:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
> > .kernel.org%2Fr%2F20251212-nor-v1-1-20a5a381979c%40nxp.com&data=05
> %7C0
> >
> 2%7Chaibo.chen%40nxp.com%7C9a2bf553aac042c4139208de4170560f%7C68
> 6ea1d3
> >
> bc2b4c6fa92cd99c5c301635%7C0%7C0%7C639020147896277357%7CUnknown
> %7CTWFp
> >
> bGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiI
> sIk
> >
> FOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=pvXNIZ%2BXuZUX
> Hz6YJe
> > 3bOz%2FobRo1Nxv0prnqlPqeG5c%3D&reserved=0
> > ---
> [...]
> > ---
> >  drivers/mtd/spi-nor/micron-st.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/micron-st.c
> > b/drivers/mtd/spi-nor/micron-st.c index
> >
> 88033384a71e5d19f5a26ca91f56a49e3017183a..5797bb748be696b340ff1398
> 155f
> > 5ac8b1f74055 100644
> > --- a/drivers/mtd/spi-nor/micron-st.c
> > +++ b/drivers/mtd/spi-nor/micron-st.c
> > @@ -167,6 +167,10 @@ static int mt35xu512aba_post_sfdp_fixup(struct
> spi_nor *nor)
> >  				  0, 20, SPINOR_OP_MT_DTR_RD,
> >  				  SNOR_PROTO_8_8_8_DTR);
> >
> 
> Please also add a comment here explaining why this fixup is needed, as Michael
> suggested in v1. Probably a shorter version of the explanation in the commit
> message.

Sure, will add in next version.

Regards
Haibo Chen
> 
> With that, feel free to add:
> 
> Reviewed-by: Pratyush Yadav <pratyush@...nel.org>
> 
> > +	nor->params->hwcaps.mask |= SNOR_HWCAPS_PP_8_8_8_DTR;
> > +
> 	spi_nor_set_pp_settings(&nor->params->page_programs[SNOR_CMD_PP_
> 8_8_8_DTR],
> > +				SPINOR_OP_PP_4B, SNOR_PROTO_8_8_8_DTR);
> > +
> >  	nor->cmd_ext_type = SPI_NOR_EXT_REPEAT;
> >  	nor->params->rdsr_dummy = 8;
> >  	nor->params->rdsr_addr_nbytes = 0;
> >
> > ---
> > base-commit: 4a5663c04bb679631985a15efab774da58c37815
> > change-id: 20251212-nor-2f37cf12eeca
> >
> > Best regards,
> 
> --
> Regards,
> Pratyush Yadav