linux-kernel - Re: [PATCH v1] perf symbol: Fix ENOENT case for filename__read_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176651386912.34483.44621848769631733.b4-ty@kernel.org>
Date: Tue, 23 Dec 2025 10:17:49 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
 Arnaldo Carvalho de Melo <acme@...nel.org>, 
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
 James Clark <james.clark@...aro.org>, 
 Stephen Brennan <stephen.s.brennan@...cle.com>, 
 Haibo Xu <haibo1.xu@...el.com>, linux-perf-users@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH v1] perf symbol: Fix ENOENT case for
 filename__read_build_id

On Sat, 06 Dec 2025 18:23:45 -0800, Ian Rogers wrote:
> Some callers of filename__read_build_id assume the error value must be
> -1, fix by making them handle all < 0 values.
> 
> If is_regular_file fails in filename__read_build_id then it could be
> the file is missing (ENOENT) and it would be wrong to return
> -EWOULDBLOCK in that case. Fix the logic so -EWOULDBLOCK is only
> reported if other errors with stat haven't occurred.
> 
> [...]
Applied to perf-tools, thanks!

Best regards,
Namhyung