linux-kernel - [PATCH] PCI: amd-mdb: fix incorrect IRQ number in INTx error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251223184003.32950-1-rakuram.e96@gmail.com>
Date: Wed, 24 Dec 2025 00:10:03 +0530
From: Rakuram Eswaran <rakuram.e96@...il.com>
To: lpieralisi@...nel.org,
	kwilczynski@...nel.org,
	mani@...nel.org,
	robh@...nel.org,
	bhelgaas@...gle.com
Cc: lkp@...el.com,
	error27@...il.com,
	sai.krishna.musham@....com,
	tglx@...utronix.de,
	jirislaby@...nel.org,
	thippeswamy.havalige@....com,
	linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Rakuram Eswaran <rakuram.e96@...il.com>,
	Dan Carpenter <dan.carpenter@...aro.org>
Subject: [PATCH] PCI: amd-mdb: fix incorrect IRQ number in INTx error message

The INTx devm_request_irq() failure path logs an incorrect IRQ
number. The printed 'irq' variable refers to a previous MDB
interrupt mapping and does not correspond to the INTx IRQ being
requested.

Fix the error message to report pcie->intx_irq, which is the IRQ
associated with the failing request.

Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
Closes: https://lore.kernel.org/r/202512230112.AaiGqMWM-lkp@intel.com/
Signed-off-by: Rakuram Eswaran <rakuram.e96@...il.com>
---
Testing note:
Compile-tested only.

Static analysis was performed with Smatch to ensure the reported warning
no longer reproduces after applying this fix.

Command using for testing:
~/project/smatch/smatch_scripts/kchecker ./drivers/pci/controller/dwc/pcie-amd-mdb.c

 drivers/pci/controller/dwc/pcie-amd-mdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-amd-mdb.c b/drivers/pci/controller/dwc/pcie-amd-mdb.c
index 3c6e837465bb..7e50e11fbffd 100644
--- a/drivers/pci/controller/dwc/pcie-amd-mdb.c
+++ b/drivers/pci/controller/dwc/pcie-amd-mdb.c
@@ -389,7 +389,7 @@ static int amd_mdb_setup_irq(struct amd_mdb_pcie *pcie,
 			       IRQF_NO_THREAD, NULL, pcie);
 	if (err) {
 		dev_err(dev, "Failed to request INTx IRQ %d, err=%d\n",
-			irq, err);
+			pcie->intx_irq, err);
 		return err;
 	}
 
-- 
2.51.0