| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251223183142.31897-2-damien.riegel@silabs.com>
Date: Tue, 23 Dec 2025 13:31:35 -0500
From: Damien Riégel <damien.riegel@...abs.com>
To: greybus-dev@...ts.linaro.org
Cc: linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org>,
Alex Elder <elder@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-devel@...abs.com,
Damien Riégel <damien.riegel@...abs.com>
Subject: [PATCH 1/8] greybus: add P2P interface type
Introduce a new Point-To-Point interface type. This type of interface is
used to indicate that this interface belongs to a module that's
connected in a point-to-point setup with a host device.
In this configuration, there is no SVC in the bus, so all code paths
that use the SVC are skipped when dealing with this kind of interface.
Signed-off-by: Damien Riégel <damien.riegel@...abs.com>
---
drivers/greybus/connection.c | 5 +++
drivers/greybus/interface.c | 52 +++++++++++++++++++++----------
include/linux/greybus/interface.h | 1 +
3 files changed, 42 insertions(+), 16 deletions(-)
diff --git a/drivers/greybus/connection.c b/drivers/greybus/connection.c
index 9c88861986c..f9287f2f4c9 100644
--- a/drivers/greybus/connection.c
+++ b/drivers/greybus/connection.c
@@ -407,6 +407,8 @@ gb_connection_svc_connection_create(struct gb_connection *connection)
return 0;
intf = connection->intf;
+ if (intf->type == GB_INTERFACE_TYPE_P2P)
+ return 0;
/*
* Enable either E2EFC or CSD, unless no flow control is requested.
@@ -441,6 +443,9 @@ gb_connection_svc_connection_destroy(struct gb_connection *connection)
if (gb_connection_is_static(connection))
return;
+ if (connection->intf->type == GB_INTERFACE_TYPE_P2P)
+ return;
+
gb_svc_connection_destroy(connection->hd->svc,
connection->hd->svc->ap_intf_id,
connection->hd_cport_id,
diff --git a/drivers/greybus/interface.c b/drivers/greybus/interface.c
index a0f3e942272..e96b58b211b 100644
--- a/drivers/greybus/interface.c
+++ b/drivers/greybus/interface.c
@@ -711,6 +711,9 @@ static int gb_interface_suspend(struct device *dev)
if (ret)
goto err_hibernate_abort;
+ if (intf->type == GB_INTERFACE_TYPE_P2P)
+ return 0;
+
ret = gb_interface_hibernate_link(intf);
if (ret)
return ret;
@@ -733,16 +736,19 @@ static int gb_interface_suspend(struct device *dev)
static int gb_interface_resume(struct device *dev)
{
struct gb_interface *intf = to_gb_interface(dev);
- struct gb_svc *svc = intf->hd->svc;
int ret;
- ret = gb_interface_refclk_set(intf, true);
- if (ret)
- return ret;
+ if (intf->type != GB_INTERFACE_TYPE_P2P) {
+ struct gb_svc *svc = intf->hd->svc;
- ret = gb_svc_intf_resume(svc, intf->interface_id);
- if (ret)
- return ret;
+ ret = gb_interface_refclk_set(intf, true);
+ if (ret)
+ return ret;
+
+ ret = gb_svc_intf_resume(svc, intf->interface_id);
+ if (ret)
+ return ret;
+ }
ret = gb_control_resume(intf->control);
if (ret)
@@ -924,6 +930,11 @@ static int _gb_interface_activate(struct gb_interface *intf,
if (intf->ejected || intf->removed)
return -ENODEV;
+ if (intf->type == GB_INTERFACE_TYPE_P2P) {
+ *type = GB_INTERFACE_TYPE_P2P;
+ goto make_active;
+ }
+
ret = gb_interface_vsys_set(intf, true);
if (ret)
return ret;
@@ -955,6 +966,7 @@ static int _gb_interface_activate(struct gb_interface *intf,
if (ret)
goto err_hibernate_link;
+make_active:
intf->active = true;
trace_gb_interface_activate(intf);
@@ -1012,6 +1024,7 @@ int gb_interface_activate(struct gb_interface *intf)
case GB_INTERFACE_TYPE_GREYBUS:
ret = _gb_interface_activate_es3_hack(intf, &type);
break;
+ case GB_INTERFACE_TYPE_P2P:
default:
ret = _gb_interface_activate(intf, &type);
}
@@ -1049,11 +1062,13 @@ void gb_interface_deactivate(struct gb_interface *intf)
if (intf->mode_switch)
complete(&intf->mode_switch_completion);
- gb_interface_route_destroy(intf);
- gb_interface_hibernate_link(intf);
- gb_interface_unipro_set(intf, false);
- gb_interface_refclk_set(intf, false);
- gb_interface_vsys_set(intf, false);
+ if (intf->type != GB_INTERFACE_TYPE_P2P) {
+ gb_interface_route_destroy(intf);
+ gb_interface_hibernate_link(intf);
+ gb_interface_unipro_set(intf, false);
+ gb_interface_refclk_set(intf, false);
+ gb_interface_vsys_set(intf, false);
+ }
intf->active = false;
}
@@ -1072,10 +1087,12 @@ int gb_interface_enable(struct gb_interface *intf)
int ret, size;
void *manifest;
- ret = gb_interface_read_and_clear_init_status(intf);
- if (ret) {
- dev_err(&intf->dev, "failed to clear init status: %d\n", ret);
- return ret;
+ if (intf->type != GB_INTERFACE_TYPE_P2P) {
+ ret = gb_interface_read_and_clear_init_status(intf);
+ if (ret) {
+ dev_err(&intf->dev, "failed to clear init status: %d\n", ret);
+ return ret;
+ }
}
/* Establish control connection */
@@ -1230,6 +1247,9 @@ int gb_interface_add(struct gb_interface *intf)
gb_interface_type_string(intf));
switch (intf->type) {
+ case GB_INTERFACE_TYPE_P2P:
+ dev_info(&intf->dev, "Added P2P interface\n");
+ break;
case GB_INTERFACE_TYPE_GREYBUS:
dev_info(&intf->dev, "GMP VID=0x%08x, PID=0x%08x\n",
intf->vendor_id, intf->product_id);
diff --git a/include/linux/greybus/interface.h b/include/linux/greybus/interface.h
index ce4def881e6..fed6356eb13 100644
--- a/include/linux/greybus/interface.h
+++ b/include/linux/greybus/interface.h
@@ -18,6 +18,7 @@ enum gb_interface_type {
GB_INTERFACE_TYPE_DUMMY,
GB_INTERFACE_TYPE_UNIPRO,
GB_INTERFACE_TYPE_GREYBUS,
+ GB_INTERFACE_TYPE_P2P,
};
#define GB_INTERFACE_QUIRK_NO_CPORT_FEATURES BIT(0)
--
2.49.0
Powered by blists - more mailing lists