linux-kernel - Re: [PATCH] perf symbol: remove Rust symbol workarounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DF5UVBWESS8Y.2M1TCH1OIT9EP@kernel.org>
Date: Tue, 23 Dec 2025 20:50:14 +0100
From: "Benno Lossin" <lossin@...nel.org>
To: "Gary Guo" <gary@...yguo.net>, "Peter Zijlstra" <peterz@...radead.org>,
 "Ingo Molnar" <mingo@...hat.com>, "Arnaldo Carvalho de Melo"
 <acme@...nel.org>, "Namhyung Kim" <namhyung@...nel.org>, "Mark Rutland"
 <mark.rutland@....com>, "Alexander Shishkin"
 <alexander.shishkin@...ux.intel.com>, "Jiri Olsa" <jolsa@...nel.org>, "Ian
 Rogers" <irogers@...gle.com>, "Adrian Hunter" <adrian.hunter@...el.com>,
 "James Clark" <james.clark@...aro.org>, "Miguel Ojeda" <ojeda@...nel.org>,
 "Boqun Feng" <boqun.feng@...il.com>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
 "Danilo Krummrich" <dakr@...nel.org>, "Nathan Chancellor"
 <nathan@...nel.org>, "Nick Desaulniers" <nick.desaulniers+lkml@...il.com>,
 "Bill Wendling" <morbo@...gle.com>, "Justin Stitt"
 <justinstitt@...gle.com>, "Andi Kleen" <ak@...ux.intel.com>, "Dmitry
 Vyukov" <dvyukov@...gle.com>, "Stephen Brennan"
 <stephen.s.brennan@...cle.com>
Cc: "Arnaldo Carvalho de Melo" <acme@...hat.com>,
 <linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>, <llvm@...ts.linux.dev>
Subject: Re: [PATCH] perf symbol: remove Rust symbol workarounds

On Tue Dec 23, 2025 at 6:52 PM CET, Gary Guo wrote:
> From: Gary Guo <gary@...yguo.net>
>
> Due to an off-by-one error introduced in commit 73bbb94466fd ("kallsyms:
> support "big" kernel symbols"), long symbols (which are currently only
> produced by Rust) can have their symbol type being wrongly parsed by
> kernel/kallsyms.c.
>
> This has been fixed in commit f3f9f42232dee5 ("kallsyms: Fix wrong "big"
> kernel symbol type read from procfs"), and these symbols are now
> reported correctly.
>
> Drop the workaround in perf symbol that filter out these symbol types.
>
> Specifically, '1' and 'l' can never be generated by nm -- 'u' does
> indicate GNU unique, however such symbols are only generated by G++ for
> C++ templates, and are never generated by LLVM (LLVM generates weak
> symbols in such cases instead). Therefore, the previous occurrence of
> these symbols types must be due to the off-by-error and can be safely

Typo: off-by-one error

Cheers,
Benno

> removed.
>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Miguel Ojeda <ojeda@...nel.org>
> Signed-off-by: Gary Guo <gary@...yguo.net>
> ---
>  tools/perf/util/symbol.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)