linux-kernel - Re: [PATCH] tracing: Do not register unsupported perf events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251223164652.6153a392@gandalf.local.home>
Date: Tue, 23 Dec 2025 16:46:52 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux Trace Kernel
 <linux-trace-kernel@...r.kernel.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Ian Rogers <irogers@...gle.com>, Arnaldo Carvalho de Melo
 <acme@...nel.org>, Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH] tracing: Do not register unsupported perf events

On Tue, 23 Dec 2025 10:22:18 -0800
Namhyung Kim <namhyung@...nel.org> wrote:

> Reviewed-by: Namhyung Kim <namhyung@...nel.org>
> 
> Thanks,
> Namhyung
> 
> > ---
> >  kernel/trace/trace_events.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> > index a5a93d243047..754b14ca87a7 100644
> > --- a/kernel/trace/trace_events.c
> > +++ b/kernel/trace/trace_events.c
> > @@ -710,6 +710,8 @@ int trace_event_reg(struct trace_event_call *call,
> >  
> >  #ifdef CONFIG_PERF_EVENTS
> >  	case TRACE_REG_PERF_REGISTER:
> > +		if (!call->class->perf_probe)
> > +			return -ENODEV;

Thanks Namhyung (and Jiri), but this actually already made it upstream as
it was a bug fix and I wanted to get it into the next rc release (rc2).

But, the real fix is having perf be able to handle synthetic_events as real
events.

Can you please review this patch:

  https://lore.kernel.org/linux-trace-kernel/20251217113920.50b56246@gandalf.local.home/

I plan on queuing that for the next merge window.

Thanks,

-- Steve


> >  		return tracepoint_probe_register(call->tp,
> >  						 call->class->perf_probe,
> >  						 call);
> > --