linux-kernel - [PATCH] iommufd: fix selftest link dependency on amdv1 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251223215127.603969-1-arnd@kernel.org>
Date: Tue, 23 Dec 2025 22:51:22 +0100
From: Arnd Bergmann <arnd@...nel.org>
To: Jason Gunthorpe <jgg@...pe.ca>,
	Kevin Tian <kevin.tian@...el.com>,
	Joerg Roedel <joro@...tes.org>,
	Will Deacon <will@...nel.org>,
	Samiullah Khawaja <skhawaja@...gle.com>
Cc: Arnd Bergmann <arnd@...db.de>,
	Robin Murphy <robin.murphy@....com>,
	Nicolin Chen <nicolinc@...dia.com>,
	Lu Baolu <baolu.lu@...ux.intel.com>,
	Pranjal Shrivastava <praan@...gle.com>,
	Yi Liu <yi.l.liu@...el.com>,
	iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: [PATCH] iommufd: fix selftest link dependency on amdv1 driver

From: Arnd Bergmann <arnd@...db.de>

When CONFIG_AMD_IOMMU is disabled, the selftest runs into a link failure:

aarch64-linux-ld: drivers/iommu/iommufd/selftest.o: in function `mock_domain_alloc_pgtable.isra.0':
selftest.c:(.text+0x1590): undefined reference to `pt_iommu_amdv1_init'
aarch64-linux-ld: drivers/iommu/iommufd/selftest.o:(.rodata+0x280): undefined reference to `pt_iommu_amdv1_map_pages'
aarch64-linux-ld: drivers/iommu/iommufd/selftest.o:(.rodata+0x288): undefined reference to `pt_iommu_amdv1_unmap_pages'
aarch64-linux-ld: drivers/iommu/iommufd/selftest.o:(.rodata+0x2b0): undefined reference to `pt_iommu_amdv1_iova_to_phys'
aarch64-linux-ld: drivers/iommu/iommufd/selftest.o:(.rodata+0x2d8): undefined reference to `pt_iommu_amdv1_read_and_clear_dirty'

Change the top-level function to skip all the amdv1 tests in this configuration.

Fixes: e93d5945ed5b ("iommufd: Change the selftest to use iommupt instead of xarray")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/iommu/iommufd/selftest.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/iommu/iommufd/selftest.c b/drivers/iommu/iommufd/selftest.c
index 550ff36dec3a..4d04d7642b1b 100644
--- a/drivers/iommu/iommufd/selftest.c
+++ b/drivers/iommu/iommufd/selftest.c
@@ -479,6 +479,11 @@ mock_domain_alloc_pgtable(struct device *dev,
 	}
 
 	case MOCK_IOMMUPT_AMDV1: {
+		if (!IS_ENABLED(CONFIG_AMD_IOMMU)) {
+			rc = -EOPNOTSUPP;
+			goto err_free;
+		}
+
 		struct pt_iommu_amdv1_cfg cfg = {};
 
 		cfg.common.hw_max_vasz_lg2 = 64;
-- 
2.39.5