linux-kernel - Re: [PATCH v11 0/2] Support for Osram as3668 LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUsN9pK1i3u5D8Uc@archstation>
Date: Tue, 23 Dec 2025 22:52:14 +0100
From: Lukas Timmermann <linux@...mermann.space>
To: Lee Jones <lee@...nel.org>, pavel@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-leds@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 0/2] Support for Osram as3668 LED driver

On Sun, Dec 14, 2025 at 03:35:12PM +0000, Lee Jones wrote:
> On Tue, 25 Nov 2025 12:40:13 +0100, Lukas Timmermann wrote:
> > This patch adds basic support for the as3668 driver IC via I2C interface.
> > The IC is capable of driving four individual LEDs up to 25.5mA per
> > channel. Hardware blinking would be theoretically possible, but this chip
> > only supports a few set on/off-delays which makes using that feature
> > unfeasable, therefore my driver doesn't offer that capability.
> > It's intended applications is in mobile devices such as phones,
> > tablets and cameras. This driver was tested and is working on
> > a google-manta which is running postmarketOS with a near mainline kernel.
> > Also there is a patch in the linux mailing list for that device:
> > https://lore.kernel.org/all/20251120201958.1970828-1-linux@timmermann.space/
> > The register names and values are taken from the official datasheet which
> > can be found here:
> > https://www.mouser.com/datasheet/2/588/AS3668_DS000196_1-00-1512816.pdf
> > 
> > [...]
> 
> Applied, thanks!
Overall great news, thanks. There is a newer version (v13) with a few fixes
available here:
https://lore.kernel.org/all/20251201230601.285641-1-linux@timmermann.space/
Have you seen this version? 
There are smaller corrections around as3668_channel_mode_set()
Could be worth to drop this version and reapply. What are your thoughts on this?

Best regards
Lukas Timmermann
> 
> [1/2] dt-bindings: leds: Add new as3668 support
>       commit: a093bc82b6013c40add22b96deed4d2b67905f41
> [2/2] leds: as3668: Driver for the ams Osram 4-channel i2c LED driver
>       commit: 8856d7fe1758937ac528770f552ec58c388c255b
> 
> --
> Lee Jones [李琼斯]
> 
>