[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <vif3wnb5zbfsz6hpy3fcesiuav2hcc2cwflnzxjk67ysfiuwfj@sktqfukjjuog>
Date: Wed, 24 Dec 2025 00:07:26 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Akhil P Oommen <akhilpo@....qualcomm.com>
Cc: david@...t.cz, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: qcom: sdm845-oneplus: Update firmware
paths
On Tue, Dec 23, 2025 at 01:01:42AM +0530, Akhil P Oommen wrote:
> On 12/23/2025 12:35 AM, David Heidelberg via B4 Relay wrote:
> > From: David Heidelberg <david@...t.cz>
> >
> > Conform to the new firmware path scheme.
> > Includes cosmetic cleanups.
> >
> > Signed-off-by: David Heidelberg <david@...t.cz>
> > ---
> > .../arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 23 ++++++++++++++--------
> > 1 file changed, 15 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> > index db6dd04c51bb5..f1c63794db979 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> > @@ -181,8 +181,9 @@ panel_vddi_poc_1p8: panel-vddi-poc-regulator {
> > };
> >
> > &adsp_pas {
> > + firmware-name = "qcom/sdm845/OnePlus/enchilada/adsp.mbn";
> > +
> > status = "okay";
> > - firmware-name = "qcom/sdm845/oneplus6/adsp.mbn";
> > };
> >
> > &apps_rsc {
> > @@ -353,8 +354,9 @@ vreg_s3c_0p6: smps3 {
> > };
> >
> > &cdsp_pas {
> > + firmware-name = "qcom/sdm845/OnePlus/enchilada/cdsp.mbn";
> > +
> > status = "okay";
> > - firmware-name = "qcom/sdm845/oneplus6/cdsp.mbn";
> > };
> >
> > &gcc {
> > @@ -370,7 +372,7 @@ &gpu {
> > };
> >
> > &gpu_zap_shader {
> > - firmware-name = "qcom/sdm845/oneplus6/a630_zap.mbn";
> > + firmware-name = "qcom/sdm845/OnePlus/enchilada/a630_zap.mbn";
>
> I believe this is considered as breaking backward compatibility. How
> about creating a symlink in linux-firmware instead.
OnePlus is not supported in linux-firmware.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
--
With best wishes
Dmitry
Powered by blists - more mailing lists