linux-kernel - Re: [PATCH 3/5 v8] acpi/ghes: Add helper for CPER CXL protocol errors checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202512240711.Iv57ik8I-lkp@intel.com>
Date: Wed, 24 Dec 2025 07:58:45 +0800
From: kernel test robot <lkp@...el.com>
To: "Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
	linux-cxl@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Rafael J Wysocki <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>, Tony Luck <tony.luck@...el.com>,
	Borislav Petkov <bp@...en8.de>, Hanjun Guo <guohanjun@...wei.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org, Shuai Xue <xueshuai@...ux.alibaba.com>,
	Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Mahesh J Salgaonkar <mahesh@...ux.ibm.com>,
	Oliver O'Halloran <oohall@...il.com>,
	Bjorn Helgaas <helgaas@...nel.org>, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	linux-pci@...r.kernel.org,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>
Subject: Re: [PATCH 3/5 v8] acpi/ghes: Add helper for CPER CXL protocol
 errors checks

Hi Fabio,

kernel test robot noticed the following build errors:

[auto build test ERROR on ea1013c1539270e372fc99854bc6e4d94eaeff66]

url:    https://github.com/intel-lab-lkp/linux/commits/Fabio-M-De-Francesco/ACPI-extlog-Trace-CPER-Non-standard-Section-Body/20251219-204338
base:   ea1013c1539270e372fc99854bc6e4d94eaeff66
patch link:    https://lore.kernel.org/r/20251219124042.3759749-4-fabio.m.de.francesco%40linux.intel.com
patch subject: [PATCH 3/5 v8] acpi/ghes: Add helper for CPER CXL protocol errors checks
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20251224/202512240711.Iv57ik8I-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251224/202512240711.Iv57ik8I-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512240711.Iv57ik8I-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/acpi/apei/ghes_helpers.c: In function 'cxl_cper_sec_prot_err_valid':
>> drivers/acpi/apei/ghes_helpers.c:9:17: error: implicit declaration of function 'pr_err_ratelimited' [-Wimplicit-function-declaration]
       9 |                 pr_err_ratelimited("CXL CPER invalid agent type\n");
         |                 ^~~~~~~~~~~~~~~~~~
>> drivers/acpi/apei/ghes_helpers.c:27:17: error: implicit declaration of function 'pr_warn_ratelimited' [-Wimplicit-function-declaration]
      27 |                 pr_warn_ratelimited(FW_WARN
         |                 ^~~~~~~~~~~~~~~~~~~
>> drivers/acpi/apei/ghes_helpers.c:27:37: error: 'FW_WARN' undeclared (first use in this function)
      27 |                 pr_warn_ratelimited(FW_WARN
         |                                     ^~~~~~~
   drivers/acpi/apei/ghes_helpers.c:27:37: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/acpi/apei/ghes_helpers.c:27:44: error: expected ')' before string constant
      27 |                 pr_warn_ratelimited(FW_WARN
         |                                    ~       ^
         |                                            )
      28 |                                     "CXL CPER no device serial number\n");
         |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/pr_err_ratelimited +9 drivers/acpi/apei/ghes_helpers.c

     5	
     6	int cxl_cper_sec_prot_err_valid(struct cxl_cper_sec_prot_err *prot_err)
     7	{
     8		if (!(prot_err->valid_bits & PROT_ERR_VALID_AGENT_ADDRESS)) {
   > 9			pr_err_ratelimited("CXL CPER invalid agent type\n");
    10			return -EINVAL;
    11		}
    12	
    13		if (!(prot_err->valid_bits & PROT_ERR_VALID_ERROR_LOG)) {
    14			pr_err_ratelimited("CXL CPER invalid protocol error log\n");
    15			return -EINVAL;
    16		}
    17	
    18		if (prot_err->err_len != sizeof(struct cxl_ras_capability_regs)) {
    19			pr_err_ratelimited("CXL CPER invalid RAS Cap size (%u)\n",
    20					   prot_err->err_len);
    21			return -EINVAL;
    22		}
    23	
    24		if ((prot_err->agent_type == RCD || prot_err->agent_type == DEVICE ||
    25		     prot_err->agent_type == LD || prot_err->agent_type == FMLD) &&
    26		    !(prot_err->valid_bits & PROT_ERR_VALID_SERIAL_NUMBER))
  > 27			pr_warn_ratelimited(FW_WARN

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki