linux-kernel - Re: [PATCH v2 4/5] selftests/mm: va_high_addr_switch return fail when either test failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251222185618.e5c3e0303cdc5f34c45c9a29@linux-foundation.org>
Date: Mon, 22 Dec 2025 18:56:18 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Chunyu Hu <chuhu@...hat.com>
Cc: Luiz Capitulino <luizcap@...hat.com>, david@...nel.org,
 shuah@...nel.org, linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, lorenzo.stoakes@...cle.com,
 Liam.Howlett@...cle.com, vbabka@...e.cz, rppt@...nel.org,
 surenb@...gle.com, mhocko@...e.com
Subject: Re: [PATCH v2 4/5] selftests/mm: va_high_addr_switch return fail
 when either test failed

On Tue, 23 Dec 2025 10:46:18 +0800 Chunyu Hu <chuhu@...hat.com> wrote:

> > >   int main(int argc, char **argv)
> > >   {
> > > -	int ret;
> > > +	int ret, hugetlb_ret = KSFT_PASS;
> > >   	if (!supported_arch())
> > >   		return KSFT_SKIP;
> > > @@ -331,6 +331,10 @@ int main(int argc, char **argv)
> > >   	ret = run_test(testcases, sz_testcases);
> > >   	if (argc == 2 && !strcmp(argv[1], "--run-hugetlb"))
> > > -		ret = run_test(hugetlb_testcases, sz_hugetlb_testcases);
> > 
> > Maybe you could just have used:
> > 
> > 		ret |= run_test(hugetlb_testcases, sz_hugetlb_testcases);
> 
> Good point. I thought the result code is not encoded by bit, but for
> KSFT_PASS and KSFT_FAIL, and KSFT_SKIP, they are per bit.
> 
>    85 #define KSFT_PASS  0
>    86 #define KSFT_FAIL  1
>    87 #define KSFT_XFAIL 2
>    88 #define KSFT_XPASS 3
>    89 #define KSFT_SKIP  4
> 
> @Andrew, do you think I need to send a v3 for using the simpified way?
> if so, send the whole series or the single patch?

Leave it as it is?  This thing isn't a bitfield, so using |= happens to
work thanks to good luck.