linux-kernel - Re: [PATCH v1 18/23] platform/chrome: cros_hps_i2c: Discard pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUoS4AxGx291bLqF@google.com>
Date: Tue, 23 Dec 2025 03:56:16 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Linux PM <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Brian Norris <briannorris@...omium.org>,
	Dan Callaghan <dcallagh@...omium.org>,
	Sami Kyöstilä <skyostil@...omium.org>,
	Benson Leung <bleung@...omium.org>, chrome-platform@...ts.linux.dev
Subject: Re: [PATCH v1 18/23] platform/chrome: cros_hps_i2c: Discard
 pm_runtime_put() return value

On Mon, Dec 22, 2025 at 09:27:44PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Passing pm_runtime_put() return value to the callers is not particularly
> useful.
> 
> Returning an error code from pm_runtime_put() merely means that it has
> not queued up a work item to check whether or not the device can be
> suspended and there are many perfectly valid situations in which that
> can happen, like after writing "on" to the devices' runtime PM "control"
> attribute in sysfs for one example.  It also happens when the kernel is
> configured with CONFIG_PM unset.
> 
> Accordingly, update hps_release() to simply discard the return value of
> pm_runtime_put() and always return success to the caller.
> 
> This will facilitate a planned change of the pm_runtime_put() return
> type to void in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Acked-by: Tzung-Bi Shih <tzungbi@...nel.org>