linux-kernel - Re: [PATCH v3 1/1] RDMA/rxe: Avoid -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bf3f157-54b7-49ed-8dc2-6948dbcf670a@embeddedor.com>
Date: Tue, 23 Dec 2025 14:18:29 +0900
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Zhu Yanjun <yanjun.zhu@...ux.dev>, zyjzyj2000@...il.com, jgg@...pe.ca,
 leon@...nel.org, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Subject: Re: [PATCH v3 1/1] RDMA/rxe: Avoid -Wflex-array-member-not-at-end
 warnings

On 12/23/25 14:10, Zhu Yanjun wrote:
> 
> 在 2025/12/22 21:03, Gustavo A. R. Silva 写道:
>>
>>
>> On 12/23/25 13:41, Zhu Yanjun wrote:
>>> From: "Gustavo A. R. Silva" <gustavoars@...nel.org>
>>>
>>> -Wflex-array-member-not-at-end was introduced in GCC-14, and we are
>>> getting ready to enable it, globally.
>>>
>>> Use the new TRAILING_OVERLAP() helper to fix the following warning:
>>>
>>> 21 drivers/infiniband/sw/rxe/rxe_verbs.h:271:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array- 
>>> member-not-at-end]
>>>
>>> This helper creates a union between a flexible-array member (FAM) and a
>>> set of MEMBERS that would otherwise follow it.
>>>
>>> This overlays the trailing MEMBER struct ib_sge sge[RXE_MAX_SGE]; onto
>>> the FAM struct rxe_recv_wqe::dma.sge, while keeping the FAM and the
>>> start of MEMBER aligned.
>>>
>>> The static_assert() ensures this alignment remains, and it's
>>> intentionally placed inmediately after the related structure --no
>>> blank line in between.
>>>
>>> Lastly, move the conflicting declaration struct rxe_resp_info resp;
>>> to the end of the corresponding structure.
>>>
>>> Reviewed-by: Zhu Yanjun <yanjun.zhu@...ux.dev>
>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
>>> ---
>>> V2->V3: Replace struct ib_sge with struct rxe_sge
>>
>> What are you doing?
> 
> Because struct rxe_sge differs from struct ib_sge, I aligned it to use the same structure.

Listen, this is not how things are done upstream. Read what I previously commented:

>> You're making a mess of this whole thing. Please, don't make changes
>> to my patches on your own.

and please, learn how to properly submit patch series.

Lastly, do the changes that you want/need to implement in your code, and don't
submit my patch as part of those changes again.

-Gustavo