linux-kernel - Re: [PATCH net-next] net: gve: convert to use .get_rx_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEAWyHeB4JgXTm-a=QpSNkgV95vVCmkeL_usFwHZNUZiS0hOEA@mail.gmail.com>
Date: Mon, 22 Dec 2025 21:22:45 -0800
From: Harshitha Ramamurthy <hramamurthy@...gle.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Joshua Washington <joshwash@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: gve: convert to use .get_rx_ring_count

On Mon, Dec 22, 2025 at 9:19 AM Breno Leitao <leitao@...ian.org> wrote:
>
> Convert the Google Virtual Ethernet (GVE) driver to use the new
> .get_rx_ring_count ethtool operation instead of handling
> ETHTOOL_GRXRINGS in .get_rxnfc. This simplifies the code by moving the
> ring count query to a dedicated callback.
>
> The new callback provides the same functionality in a more direct way,
> following the ongoing ethtool API modernization.
>
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Harshitha Ramamurthy <hramamurthy@...gle.com>

Thanks!

> ---
> PS: This was compile-tested only.
> ---
>  drivers/net/ethernet/google/gve/gve_ethtool.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c
> index 52500ae8348e..9ed1d4529427 100644
> --- a/drivers/net/ethernet/google/gve/gve_ethtool.c
> +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
> @@ -815,15 +815,19 @@ static int gve_set_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd)
>         return err;
>  }
>
> +static u32 gve_get_rx_ring_count(struct net_device *netdev)
> +{
> +       struct gve_priv *priv = netdev_priv(netdev);
> +
> +       return priv->rx_cfg.num_queues;
> +}
> +
>  static int gve_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd, u32 *rule_locs)
>  {
>         struct gve_priv *priv = netdev_priv(netdev);
>         int err = 0;
>
>         switch (cmd->cmd) {
> -       case ETHTOOL_GRXRINGS:
> -               cmd->data = priv->rx_cfg.num_queues;
> -               break;
>         case ETHTOOL_GRXCLSRLCNT:
>                 if (!priv->max_flow_rules)
>                         return -EOPNOTSUPP;
> @@ -966,6 +970,7 @@ const struct ethtool_ops gve_ethtool_ops = {
>         .get_channels = gve_get_channels,
>         .set_rxnfc = gve_set_rxnfc,
>         .get_rxnfc = gve_get_rxnfc,
> +       .get_rx_ring_count = gve_get_rx_ring_count,
>         .get_rxfh_indir_size = gve_get_rxfh_indir_size,
>         .get_rxfh_key_size = gve_get_rxfh_key_size,
>         .get_rxfh = gve_get_rxfh,
>
> ---
> base-commit: 7b8e9264f55a9c320f398e337d215e68cca50131
> change-id: 20251222-gxring_google-d6c76c372f76
>
> Best regards,
> --
> Breno Leitao <leitao@...ian.org>
>